Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinGW Makefiles build in AppVeyor Windows - implicit declaration of function 'dup' #21

Open
connorimes opened this issue Jan 25, 2017 · 0 comments

Comments

@connorimes
Copy link
Member

I haven't been able to figure this one out. I think the compiler is not defining _MSC_VER so that io.h is not included, but I don't want to remove the check for it at the risk of breaking other builds that servo supports. Trying to use _dup also produces an implicit declaration message.

C:\projects\heartbeats-simple\src\hb.c:105:3: warning: implicit declaration of function 'dup' [-Wimplicit-function-declaration]
   FILE* log = fdopen(dup(fd), "w");
   ^

Perhaps there is a better way to get a FILE* from a file descriptor that we can properly cleanup without closing the underlying fd when we're finished that doesn't use dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant