From cb0792fc5c9e63593cf1a1e049df5925e50e14be Mon Sep 17 00:00:00 2001 From: Anish Ramasekar Date: Mon, 14 Sep 2020 13:30:09 -0700 Subject: [PATCH] add option to set --grpc-supported-providers in helm charts --- manifest_staging/charts/secrets-store-csi-driver/README.md | 1 + .../templates/secrets-store-csi-driver-windows.yaml | 3 +++ .../templates/secrets-store-csi-driver.yaml | 3 +++ manifest_staging/charts/secrets-store-csi-driver/values.yaml | 3 +++ 4 files changed, 10 insertions(+) diff --git a/manifest_staging/charts/secrets-store-csi-driver/README.md b/manifest_staging/charts/secrets-store-csi-driver/README.md index cc322e94d..f1d65072d 100644 --- a/manifest_staging/charts/secrets-store-csi-driver/README.md +++ b/manifest_staging/charts/secrets-store-csi-driver/README.md @@ -65,3 +65,4 @@ The following table lists the configurable parameters of the csi-secrets-store-p | `rbac.install` | Install default rbac roles and bindings | true | | `syncSecret.enabled` | Enable rbac roles and bindings required for syncing to Kubernetes native secrets (the default will change to false after v0.0.14) | true | | `minimumProviderVersions` | A comma delimited list of key-value pairs of minimum provider versions with driver | `""` | +| `grpcSupportedProviders` | A `;` delimited list of providers that support grpc for driver-provider [alpha] | `""` | diff --git a/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml b/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml index c31475139..e2902d155 100644 --- a/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml +++ b/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver-windows.yaml @@ -56,6 +56,9 @@ spec: {{- if and (semverCompare ">= v0.0.9-0" .Values.windows.image.tag) .Values.minimumProviderVersions }} - "--min-provider-version={{ .Values.minimumProviderVersions }}" {{- end }} + {{- if and (semverCompare ">= v0.0.14-0" .Values.linux.image.tag) .Values.grpcSupportedProviders }} + - "--grpc-supported-providers={{ .Values.grpcSupportedProviders }}" + {{- end }} - "--metrics-addr={{ .Values.windows.metricsAddr }}" env: {{- with .Values.windows.env }} diff --git a/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml b/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml index e34bcc474..fcbee8b75 100644 --- a/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml +++ b/manifest_staging/charts/secrets-store-csi-driver/templates/secrets-store-csi-driver.yaml @@ -58,6 +58,9 @@ spec: {{- if and (semverCompare ">= v0.0.8-0" .Values.linux.image.tag) .Values.minimumProviderVersions }} - "--min-provider-version={{ .Values.minimumProviderVersions }}" {{- end }} + {{- if and (semverCompare ">= v0.0.14-0" .Values.linux.image.tag) .Values.grpcSupportedProviders }} + - "--grpc-supported-providers={{ .Values.grpcSupportedProviders }}" + {{- end }} - "--metrics-addr={{ .Values.linux.metricsAddr }}" env: {{- with .Values.linux.env }} diff --git a/manifest_staging/charts/secrets-store-csi-driver/values.yaml b/manifest_staging/charts/secrets-store-csi-driver/values.yaml index 8f51a5068..9fad32776 100644 --- a/manifest_staging/charts/secrets-store-csi-driver/values.yaml +++ b/manifest_staging/charts/secrets-store-csi-driver/values.yaml @@ -118,3 +118,6 @@ syncSecret: ## A comma delimited list of key-value pairs of minimum provider versions ## e.g. provider1=0.0.2,provider2=0.0.3 minimumProviderVersions: + +## ; delimited list of providers that support grpc for driver-provider [alpha] +grpcSupportedProviders: