You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I updated some of the commands in the GitHub actions wiki to use find instead of shellcheck **/*.sh. I ran some tests on a throwaway repo and found that the **/*.sh version only finds scripts that are within a single directory, e.g., suppose there is a project with the layout:
The shellcheck **/*.sh version of the command will only find the script_2.sh file in this example, and the others will remain unlinted. Meanwhile, the find version will lint all the scripts. I think there are more cases of the **/*.sh variant, if desired I can help migrate to the find variant.
I updated some of the commands in the GitHub actions wiki to use
find
instead ofshellcheck **/*.sh
. I ran some tests on a throwaway repo and found that the**/*.sh
version only finds scripts that are within a single directory, e.g., suppose there is a project with the layout:The
shellcheck **/*.sh
version of the command will only find thescript_2.sh
file in this example, and the others will remain unlinted. Meanwhile, the find version will lint all the scripts. I think there are more cases of the**/*.sh
variant, if desired I can help migrate to thefind
variant.https://github.com/koalaman/shellcheck/wiki/GitHub-Actions/_compare/dd7f03302b2e07b2bc9f0cc5b2fce0fb75ac2b1d
Thanks for creating shellcheck, have used it extensively and it has helped debug some extremely challenging issues.
The text was updated successfully, but these errors were encountered: