Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wiki] Shellcheck GitHub Action Commands - **/*.sh vs find #3109

Open
codecriticsceo opened this issue Dec 31, 2024 · 0 comments
Open

[wiki] Shellcheck GitHub Action Commands - **/*.sh vs find #3109

codecriticsceo opened this issue Dec 31, 2024 · 0 comments

Comments

@codecriticsceo
Copy link

I updated some of the commands in the GitHub actions wiki to use find instead of shellcheck **/*.sh. I ran some tests on a throwaway repo and found that the **/*.sh version only finds scripts that are within a single directory, e.g., suppose there is a project with the layout:

script_1.sh
dir1/script_2.sh
dir1/dir2/script_3.sh

The shellcheck **/*.sh version of the command will only find the script_2.sh file in this example, and the others will remain unlinted. Meanwhile, the find version will lint all the scripts. I think there are more cases of the **/*.sh variant, if desired I can help migrate to the find variant.

https://github.com/koalaman/shellcheck/wiki/GitHub-Actions/_compare/dd7f03302b2e07b2bc9f0cc5b2fce0fb75ac2b1d

Thanks for creating shellcheck, have used it extensively and it has helped debug some extremely challenging issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant