Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fork Merging? #308

Open
Stoatwblr opened this issue Aug 1, 2023 · 3 comments
Open

Fork Merging? #308

Stoatwblr opened this issue Aug 1, 2023 · 3 comments

Comments

@Stoatwblr
Copy link

Hi Klaus

There are a number of good ideas in the other forks (eg: console debug logging) which would be great to fold back into your "mainline" in order to avoid excess fragmentation of WthermostatBeca

Is there any chance of considering doing that?
@kalwinskidawid
Copy link

Hey, could you provide an exact link to them?

@g6094199
Copy link

Hi Klaus

There are a number of good ideas in the other forks (eg: console debug logging) which would be great to fold back into your "mainline" in order to avoid excess fragmentation of WthermostatBeca

Is there any chance of considering doing that?

normaly the forker sets an pull request on the changes to the upstream source. so this might be better communicated to the forkers issues, maybe with a link to here.

but in general getting fresh ideas and code upstream is always a good idea (fragmentaion and long term support wise)!

@Stoatwblr
Copy link
Author

Hey, could you provide an exact link to them?

I'm thinking of the fas fork, if you're not already checking it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Stoatwblr @kalwinskidawid @g6094199