From 631566750e658849b15fad19b1d3c8bc921c6916 Mon Sep 17 00:00:00 2001 From: Orel Misan Date: Thu, 23 Nov 2023 15:18:07 +0200 Subject: [PATCH] Checkup, vmi spec: Don't use host huge pages There is no need to use the host's huge pages as the memory backend of the vm under test. Signed-off-by: Orel Misan --- pkg/internal/checkup/checkup.go | 3 +-- pkg/internal/checkup/vmi/vmi.go | 5 ++--- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/pkg/internal/checkup/checkup.go b/pkg/internal/checkup/checkup.go index c4d38bdd..01bb52f3 100644 --- a/pkg/internal/checkup/checkup.go +++ b/pkg/internal/checkup/checkup.go @@ -171,7 +171,6 @@ func newRealtimeVMI(checkupConfig config.Config) *kvcorev1.VirtualMachineInstanc CPUSocketsCount = 1 CPUCoresCount = 3 CPUTreadsCount = 1 - hugePageSize = "1Gi" guestMemory = "4Gi" rootDiskName = "rootdisk" cloudInitDiskName = "cloudinitdisk" @@ -187,7 +186,7 @@ user: user` vmi.WithoutCRIOCPUQuota(), vmi.WithoutCRIOIRQLoadBalancing(), vmi.WithRealtimeCPU(CPUSocketsCount, CPUCoresCount, CPUTreadsCount), - vmi.WithMemory(hugePageSize, guestMemory), + vmi.WithMemory(guestMemory), vmi.WithoutAutoAttachGraphicsDevice(), vmi.WithoutAutoAttachMemBalloon(), vmi.WithAutoAttachSerialConsole(), diff --git a/pkg/internal/checkup/vmi/vmi.go b/pkg/internal/checkup/vmi/vmi.go index dacc35c4..f0b2541a 100644 --- a/pkg/internal/checkup/vmi/vmi.go +++ b/pkg/internal/checkup/vmi/vmi.go @@ -159,12 +159,11 @@ func WithVirtIODisk(name string) Option { } } -func WithMemory(hugePageSize, guestMemory string) Option { +func WithMemory(guestMemory string) Option { return func(vmi *kvcorev1.VirtualMachineInstance) { guestMemoryQuantity := resource.MustParse(guestMemory) vmi.Spec.Domain.Memory = &kvcorev1.Memory{ - Hugepages: &kvcorev1.Hugepages{PageSize: hugePageSize}, - Guest: &guestMemoryQuantity, + Guest: &guestMemoryQuantity, } } }