Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kamu login: revisit command ergonomics #894

Open
s373r opened this issue Oct 11, 2024 · 0 comments
Open

kamu login: revisit command ergonomics #894

s373r opened this issue Oct 11, 2024 · 0 comments

Comments

@s373r
Copy link
Member

s373r commented Oct 11, 2024

At the moment, from a UX perspective, we can perform a login in three ways:

  1. kamu login password $USER $PASSWORD $KAMU_NODE_URL
  • ✅ Password authorization (calls kamu node API)
  1. kamu login oauth github $TOKEN $KAMU_NODE_URL
  • ✅ OAuth token authorization (calls kamu node API)
  1. kamu login --access-token $TOKEN $KAMU_NODE_URL
  • ⚠️ Only saves the received token to a file (.kamu/.kamutokenstore) without API calls

As a suggestion: make kamu login --access-token an alias for kamu login oauth github.

This way we will have a single code path to work with the token and the command kamu login (3).) will not be misleading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant