Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the is_ready() implementation on LagRegister #59

Open
detro opened this issue Sep 24, 2023 · 0 comments
Open

Enhance the is_ready() implementation on LagRegister #59

detro opened this issue Sep 24, 2023 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed module:lag_register

Comments

@detro
Copy link
Contributor

detro commented Sep 24, 2023

Right now, it looks like this:

#[async_trait]
impl Awaitable for LagRegister {
    async fn is_ready(&self) -> bool {
        self.lag_by_group.read().await.len() > 0
    }
}

This is pretty "weak" as readyness-check.

Something better would be to check that the registry has reached as "stable" number of groups with a stable number of registered lags against it. That might require tracking changes over multiple checks.

Ideas are welcome.

@detro detro added enhancement New feature or request help wanted Extra attention is needed module:lag_register labels Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed module:lag_register
Projects
None yet
Development

No branches or pull requests

1 participant