Having a .solhint.json with custom rules breaks the Solidity compiler server

[Jaime-Iglesias]

I've noticed that my extension was not telling me about errors, like unused parameters and stuff like that, then I noticed the message about the Solidity server crashing.

At first it was complaining about some custom rules that I have (They are for solhint 2.x), then I removed the rules (but left the .solhint.json) then it complained about it being empty. After I completely removed the .solhint.json file it did not stop crashing.

• Temportal fix: Removing the .solhint.json

[juanfranblanco]

Thanks, I have upgraded to solhint 3.0 on the latest release, I did not experienced any issues on my side even using a JSON file... obviously not enough :(

[Jaime-Iglesias]

Thanks, I have upgraded to solhint 3.0 on the latest release, I did not experienced any issues on my side even using a JSON file... obviously not enough :(

I will try installing the latest solhint version locally and use some custom rules that I already have for 3.0, I'll tell you how that goes :D

[juanfranblanco]

[Jaime-Iglesias]

So, after some extra testing I've come to the following conclusions:

1. The solhint version is not the problem.
2. Having a .solhint.json is not the problem.
3. The problem is having custom rules.

• The error.
  
• My .solhint.json file.
  
• My package.json
  

EDIT:

I wonder if this - protofire/solhint#206 - will fix it.

[juanfranblanco]

Ah what you meant by custom rules was your plugins, not your specific rules. Yes that needs to be fixed by the solhint guys... the same as before..

[Jaime-Iglesias]

Ah what you meant by custom rules was your plugins, not your specific rules. Yes that needs to be fixed by the solhint guys... the same as before..

Yeah, the problem is that it now crashes the Solidity Compiler Server which it didn't before :(

[PaulRBerg]

I'm wrestling with a similar issue now, after having recently upgraded to solhint@3.3.4. Some obvious errors are correctly highlighted:

But others, such as incorrect types, are not (underlyingOut should be an uint256):

This is with vscode-solidity@0.0.113. Deleting .solhint.json didn't fix this.

[juanfranblanco]

@PaulRBerg custom rules are not supported as it needs further work from solhint, mainly a way to inject those custom rules into the plugin. As those rules need to be loaded dynamically and found. Mainly in the user repo or something like that.

[PaulRBerg]

I don't think I am using custom rules. This is my .solhint.json file.

Also the type error above is not triggered by solhint, but the solidity compiler itself.

[juanfranblanco]

Yes you are using the "prettier" plugin @PaulRBerg

[PaulRBerg]

Ah so that's what you mean by custom rules. Gotcha.

Tagging @fvictorio (creator of the prettier plugin), in case he knows how to patch this.

[juanfranblanco]

@PaulRBerg we have some thread there protofire/solhint#206