Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding priceImpact property #12

Open
lamman1820 opened this issue Jul 15, 2021 · 6 comments
Open

Adding priceImpact property #12

lamman1820 opened this issue Jul 15, 2021 · 6 comments

Comments

@lamman1820
Copy link

Dear Author,

Can you add the priceImpact property into the Trade information?

Regards

@joshstevens19
Copy link
Owner

it's on the list will get round to this when I can! thanks

@niZmosis
Copy link

niZmosis commented Nov 6, 2021

I'd love this. It would allow me to assist the users with slippage for deflationary/fee tokens to prevent failed swaps as they require a higher slippage than normal.

@yalamber
Copy link

Thank you for this nice library, was price impact added to it, could not find it in examples.

@vm06007
Copy link

vm06007 commented Aug 28, 2022

Also curious if price impact is available @joshstevens19 / @liu-zhipeng or is planned by any chance? Most likely its not implemented yet if I'm not mistaken

@vm06007
Copy link

vm06007 commented Aug 28, 2022

Alternatively if the trade object could return reserves for each pool involved (depending on the route) this could be calculated accordingly to user input without refetching data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants
@yalamber @niZmosis @vm06007 @joshstevens19 @lamman1820 and others