Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is trace really an iterator? #42

Open
joshrule opened this issue Feb 11, 2019 · 0 comments
Open

Is trace really an iterator? #42

joshrule opened this issue Feb 11, 2019 · 0 comments

Comments

@joshrule
Copy link
Owner

We currently use Iterator to extend a Trace out from a root. The similarity between the previous step-based implementation and Iterator's next made it an easy implementation. I'm increasingly convinced, however, that we either need to remove the Iterator implementation or rework the way in which it is constructed. The overall semantics of Trace is confusing and makes it possible to compute values that the user might not intend. For example, you can build a trace with 100 nodes and then ask for the likelihood of a given rewrite in a 50 node trace, but because 100 nodes already exist, the likelihood will be over all 100 nodes rather than just 50.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant