Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to use unicode icons instead of named icons #58

Open
katzenmayer opened this issue Nov 23, 2017 · 1 comment
Open

Ability to use unicode icons instead of named icons #58

katzenmayer opened this issue Nov 23, 2017 · 1 comment

Comments

@katzenmayer
Copy link

Previous versions of your plugin were using the unicode of an icon instead of the class name. While using class names is trivial in a default setup of TinyMCE, it's nearly impossible to use it together with TinyMCE's valid_classes setting.

valid_classes does not accept wildcards like fa-* so you need to either add every possible icon class to valid_classes, or not use valid_classes at all.

With the unicode approach, only 2 classes would need to be added to valid_classes: fa and fa-spin

Perhaps it would be possible to make this a config option?

@josh18
Copy link
Owner

josh18 commented Dec 4, 2017

Sorry I don't really use this anymore so probably won't be making any further changes to it. Happy to accept a PR though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants