ux: similar subcommand tip shows deprecated subcommands

[necauqua]

Description

We have some subcommands that were removed/renamed, but we actually left a hidden stub that prints out a helpful redirect to the new name or a way to do what the subcommand did.

The similarity hint should not show those stubs.

Steps to Reproduce the Problem

1. jj reverse @-
2. tip shows subcommand 'revert' exists
3. jj revert - but 'revert' was renamed to 'backout' and surfaces a hint.

Expected Behavior

The tip should not mention 'revert', just feels a bit unpolished.

Maybe it could've been smart enough to suggest 'backout' when I did 'reverse', but that's not a point of this issue.

Actual Behavior

Specifications

• Version: jj 0.24.0-1d3c3b8ab207e66c978ed026a7393682989111c5

[martinvonz]

That's from PR #2580. Maybe we can make the error clearer.

[necauqua]

#[command(hide = true,

Seems like a clap issue then

[necauqua]

make the error clearer

No the error is fine, the issue is that the similarity tip should not list those hidden subcommands (at least in our case as we use them for those hinting stubs) nor should they be in completion - which they are, too, as I just checked

[martinvonz]

I agree but I think the hint comes from clap so it might be harder to do. Maybe we've talked about this before with the clap folks?

[bnjmnt4n]

Relevant: clap-rs/clap#4853

[yuja]

FWIW, it would be nice if revert weren't implemented as a command so user can alias it to whatever they need. I have no idea if that can be doable by inspecting clap::Error or something, though.