Error when downloading artifacts to Windows due to illegal chars in path.

[kasperpagh]

Hi folks :-)

We've recently hit a problem that we think should be "raised" to an issue on here.

We have a file stored in Artifactory under something like this:
"/file_made_at/10:15:27/file.exe"

When trying to download the file on a Windows machine we're faced with this message:

[Thread downloader_0] downloading C:\TC\t\globalTmp\1675069505929-0\<repo_name/file_made_at/2023-01-30_07:19:23:UTC/file.exe as part of file <URL_OF_ARTIFACTORY>/<REPO_NAME>/artifactory/file_made_at//2023-01-30_07:19:23:UTC/file.exe threw an exception: java.io.IOException: The filename, directory name, or volume label syntax is incorrect

We're already using a flat=true filespec, such that own own target does not include any of the "bad" chars, but we cannot stop the plugin from trying to construct a temp. dir that the OS get's angry about.

It sounds like you could, instead of constructing a temp dir using the exact path from the server, generate a random but valid folder name instead.

B/R
Kasper