From 6e1cffc16cfc9af254ff87b26639f5504f78985c Mon Sep 17 00:00:00 2001 From: Or Geva Date: Tue, 17 Oct 2023 14:17:02 +0300 Subject: [PATCH] PR review --- .github/workflows/analysis.yml | 14 +------------- main_test.go | 4 ++-- 2 files changed, 3 insertions(+), 15 deletions(-) diff --git a/.github/workflows/analysis.yml b/.github/workflows/analysis.yml index a15ea4f..1a152e6 100644 --- a/.github/workflows/analysis.yml +++ b/.github/workflows/analysis.yml @@ -1,18 +1,6 @@ name: "Static Analysis" on: [push, pull_request] jobs: - Go-Lint: - name: Lint - runs-on: ubuntu-latest - steps: - - name: Checkout code - uses: actions/checkout@v3 - - name: Install Go - uses: actions/setup-go@v3 - with: - go-version: 1.20.x - - name: Run Go vet - run: go vet -v ./... Static-Check: name: Static Check runs-on: ubuntu-latest @@ -27,7 +15,7 @@ jobs: uses: golangci/golangci-lint-action@v3 with: args: | - --timeout 5m --out-${NO_FUTURE}format colored-line-number --enable errcheck,gosimple,govet,ineffassign,staticcheck,typecheck,unused,gocritic,asasalint,asciicheck,errchkjson,exportloopref,forcetypeassert,makezero,nilerr,unparam,unconvert,wastedassign,usestdlibvars + --timeout 5m --out-${NO_FUTURE}format colored-line-number --enable errcheck,gosimple,govet,ineffassign,staticcheck,typecheck,unused,gocritic,asasalint,asciicheck,errchkjson,exportloopref,forcetypeassert,makezero,nilerr,unparam,unconvert,wastedassign,usestdlibvars Go-Sec: name: Go-Sec runs-on: ubuntu-latest diff --git a/main_test.go b/main_test.go index b990cc5..ee11563 100644 --- a/main_test.go +++ b/main_test.go @@ -52,12 +52,12 @@ func TestErroneousGoMod(t *testing.T) { } func TestMinGoVersionGoMod(t *testing.T) { - _, errs := parseGoMod(filepath.Join("testdata", "version","minor", "go.mod")) + _, errs := parseGoMod(filepath.Join("testdata", "version", "minor", "go.mod")) assert.Nil(t, errs) } func TestMinGoVersionWithPatchGoMod(t *testing.T) { - _, errs := parseGoMod(filepath.Join("testdata", "version","patch", "go.mod")) + _, errs := parseGoMod(filepath.Join("testdata", "version", "patch", "go.mod")) assert.Nil(t, errs) }