Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt plugin for Data Table API 2.0.x #634

Closed
alecharp opened this issue Mar 8, 2024 · 6 comments · Fixed by #642
Closed

Adapt plugin for Data Table API 2.0.x #634

alecharp opened this issue Mar 8, 2024 · 6 comments · Fixed by #642
Labels

Comments

@alecharp
Copy link
Member

alecharp commented Mar 8, 2024

Jenkins and plugins versions report

Environment

Jenkins 2.426+
Data Table API 2.0.1-1
master

What Operating System are you using (both controller, and any agents involved in the problem)?

N/A

Reproduction steps

Apply patch

diff --git a/pom.xml b/pom.xml
index 08de185..7c3f052 100644
--- a/pom.xml
+++ b/pom.xml
@@ -59,7 +59,7 @@
 
   <properties>
     <changelist>999999-SNAPSHOT</changelist>
-    <jenkins.version>2.387.3</jenkins.version>
+    <jenkins.version>2.426.3</jenkins.version>
     <gitHubRepo>jenkinsci/${project.artifactId}-plugin</gitHubRepo>
     <spotbugs.effort>Max</spotbugs.effort>
     <spotbugs.threshold>Low</spotbugs.threshold>
@@ -70,11 +70,16 @@
     <dependencies>
       <dependency>
         <groupId>io.jenkins.tools.bom</groupId>
-        <artifactId>bom-2.387.x</artifactId>
-        <version>2543.vfb_1a_5fb_9496d</version>
+        <artifactId>bom-2.426.x</artifactId>
+        <version>2857.v01a_0144eb_20b_</version>
         <type>pom</type>
         <scope>import</scope>
       </dependency>
+      <dependency>
+        <groupId>io.jenkins.plugins</groupId>
+        <artifactId>data-tables-api</artifactId>
+        <version>2.0.1-1</version>
+      </dependency>
     </dependencies>
   </dependencyManagement>

And visualize the resources of the instance.

You can also run mvn clean test -Dtest=org.jenkins.plugins.lockableresources.LockStepTest#unlockButtonWithWaitingRuns,org.jenkins.plugins.lockableresources.LockableResourceApiTest#reserveUnreserveApi

Expected Results

Tests are passing

Actual Results

Tests are failing.

Anything else?

This is blocking the release of BOM since the bump of Data Table API plugin jenkinsci/data-tables-api-plugin#424

Are you interested in contributing a fix?

No response

@alecharp alecharp added the bug label Mar 8, 2024
@alecharp
Copy link
Member Author

alecharp commented Mar 8, 2024

I tried to look at how the table is created but I fail to find the culprit.

@mPokornyETM
Copy link
Contributor

Ohoho . Ok I see . This need a little bit refactoring.
I need to provide 2 new features first, but when this means, the plugin will be no more usable. This one will win 😉🤷‍♂️

@jimklimov
Copy link
Contributor

jimklimov commented Mar 12, 2024

Can confirm the issue visually too: the data table seems to have a fixed size now (so overflows into scrolling when a browser window is too small, and the "Search" element above levitates far from the table when the window is too wide. With that said, about two fifths to half of the table (depending on unwrappable token length - some of our resources have long names, others don't) is a content-less gray area, literally:

image

@mPokornyETM
Copy link
Contributor

nice, this will be really tricky to analyze. :-(

@jimklimov
Copy link
Contributor

Per browser console, there are two colgroup's each with a series of col entries. The first colgroup is our usual content. The second one is the offender, specifically the first col in it:

image

@mPokornyETM
Copy link
Contributor

May somebody looks here pls
#642
thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants