-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt plugin for Data Table API 2.0.x #634
Comments
I tried to look at how the table is created but I fail to find the culprit. |
Ohoho . Ok I see . This need a little bit refactoring. |
Can confirm the issue visually too: the data table seems to have a fixed size now (so overflows into scrolling when a browser window is too small, and the "Search" element above levitates far from the table when the window is too wide. With that said, about two fifths to half of the table (depending on unwrappable token length - some of our resources have long names, others don't) is a content-less gray area, literally: |
nice, this will be really tricky to analyze. :-( |
May somebody looks here pls |
Jenkins and plugins versions report
Environment
Jenkins 2.426+
Data Table API 2.0.1-1
master
What Operating System are you using (both controller, and any agents involved in the problem)?
N/A
Reproduction steps
Apply patch
And visualize the resources of the instance.
You can also run
mvn clean test -Dtest=org.jenkins.plugins.lockableresources.LockStepTest#unlockButtonWithWaitingRuns,org.jenkins.plugins.lockableresources.LockableResourceApiTest#reserveUnreserveApi
Expected Results
Tests are passing
Actual Results
Tests are failing.
Anything else?
This is blocking the release of BOM since the bump of Data Table API plugin jenkinsci/data-tables-api-plugin#424
Are you interested in contributing a fix?
No response
The text was updated successfully, but these errors were encountered: