Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device ID does not accept Apple devices (iPhone for example) #433

Open
gabn88 opened this issue Oct 19, 2017 · 10 comments
Open

Device ID does not accept Apple devices (iPhone for example) #433

gabn88 opened this issue Oct 19, 2017 · 10 comments

Comments

@gabn88
Copy link

gabn88 commented Oct 19, 2017

The FCM deviceID now only accepts Android devices. This, while it is certainly possible to send push notifications to Apple devices using Google's FCM service.

I know it is possible to leave this field empty, but 1. it took me some time to find out why push notifications weren't working on iOS and 2. There is not good reason to only accept Android Device IDs.

@jamaalscarlett
Copy link
Member

When FCM was added, I believe it was as an update to GCM which will be phased out at some point. But you are correct, FCM does allow for push notifcations to be sent to IOS devices. Feel free to submit a pull request :)

@jamaalscarlett
Copy link
Member

This may be fixed by #386

@matthewh
Copy link
Collaborator

matthewh commented Oct 21, 2017 via email

@gabn88
Copy link
Author

gabn88 commented Oct 23, 2017

Backwards compatibility? I would say, just make a CharField of it. Of course it would be cool to validate against both the spec of Android and Apple, but I cannot find a hard spec on the device id for both? Validation is also possible on a CharField and at least this is forward compatible, which a UUID field probably is not (if it is even compatible with all existing device IDs).

@matthewh
Copy link
Collaborator

matthewh commented Oct 23, 2017

I don't disagree with you @gabn88 but @jleclanche has generally disapproved of converting the Device ID field to a CharField.

@jleclanche
Copy link
Member

Go for it.

@uber1geek
Copy link

uber1geek commented Nov 16, 2017

Has this been fixed? I was thinking to use this app for implementing push notifications for our ios and android apps via fcm with a django backend. Please advise.

@gabn88
Copy link
Author

gabn88 commented Nov 16, 2017

Just go for this module and leave the deviceID field empty on ios for now.

@sevdog
Copy link
Contributor

sevdog commented Dec 5, 2019

Any news about this? I run into this problem because UIDevice.current.identifierForVendor.uuidString returns a UUID while GCMDevice wants an HexInteger.

@sainipray
Copy link

Any update on this, because I need to save iOS device ID

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants