-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE8 placeholders for password (acceptable fix? optional fix?) #65
Comments
I am open to removing the password functionality when it is not supported (as you say that is easy to detect because the |
I agree that opt-out is probably the best as it won't break current usage. Thanks for the fast feedback, it's a really useful polyfill. |
Was a change made here? |
In IE8 when i try to modify the type of the element the below line is throwing error elem.type = "text" |
could you fix this? |
I think this is really a big problem..hope someone fix it. |
plz fix it! |
It seems that nobody maintain this repository at all. |
T_T please fix it |
IE8 hides text of password. I rather think it should not show it at all as it is very confusing for the user. One can chose to remove password from validTypes array, but then it does not work for IE9 either.
My solution was to modify showPlaceholder like this to make a check if it was possible to change type of password to text.
I basicly moved to "set value" part to after the changeType was called. If changeType fails the method returns false instead and never sets the value.
The text was updated successfully, but these errors were encountered: