Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Incorrect branches hits coverage statistic #22

Open
storenth opened this issue Dec 27, 2018 · 2 comments
Open

[Bug] Incorrect branches hits coverage statistic #22

storenth opened this issue Dec 27, 2018 · 2 comments
Labels
bug Something isn't working triaged

Comments

@storenth
Copy link

storenth commented Dec 27, 2018

When nyc report --reporter=html done, I try to look at the ./coverage/index.html and found a great defect in Branch coverage number, it always 100%. To validate this issue I suggest clone this simple repo for local reproduce.
coverage_issue

@bcoe bcoe added bug Something isn't working triaged labels Dec 29, 2018
@bcoe
Copy link
Member

bcoe commented Dec 29, 2018

thanks for the bug report; I'd be curious if this might be fixed by updating some of the dependencies of puppeteer-to-istanbul, or potentially once a newer version of v8 is released with Chrome (we've been doing a bunch of work around branch coverage).

@storenth
Copy link
Author

storenth commented Sep 20, 2019

Need to piece together puppeteer/puppeteer#3712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

2 participants