Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--api doesn't handle http/https urls appended to the multiaddr format #3292

Closed
wrouesnel opened this issue Oct 8, 2016 · 3 comments
Closed
Labels
topic/api Topic api

Comments

@wrouesnel
Copy link

Version information:

go-ipfs version: 0.4.3-
Repo version: 4
System version: amd64/linux
Golang version: go1.7

Type:

Enhancement

Priority:

P2

Description:

A fairly logical use-case for the ipfs daemon for a home user is on a network exit point with some persistently attached storage (i.e. a file server). The ipfs client already supports remote API connections with --api, and the multiaddr library supports passing https urls.

However currently the IPFS client ignores additional address path segments passed with --api
i.e. ipfs --api /ip4/192.168.1.10/tcp/443/https/ipfs-node.some-remote-server.local/ id

In both cases "Error: no protocol with name ipfs-node.some-remote-server.local" is generated in response (DNS name changed).

@whyrusleeping
Copy link
Member

cc @lgierth

@whyrusleeping whyrusleeping added the topic/api Topic api label Mar 6, 2017
@whyrusleeping whyrusleeping added this to the Ipfs 0.4.12 milestone Sep 2, 2017
@Kubuxu Kubuxu modified the milestones: Ipfs 0.4.12, go-ipfs 0.4.13 Nov 6, 2017
@hoh
Copy link

hoh commented Nov 15, 2022

I am facing this issue as well.

Fixing it in the Python aiohttp library is trivial, what prevents its implementation in the official CLI ?

@lidel
Copy link
Member

lidel commented Jan 10, 2025

Fixed in master, will be released in 0.33: #9897 (comment)

@lidel lidel closed this as completed Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic/api Topic api
Projects
None yet
Development

No branches or pull requests

5 participants