Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app init can succeed in the test but fail for the user and deployments #769

Open
g-foster2020 opened this issue Apr 18, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@g-foster2020
Copy link
Contributor

g-foster2020 commented Apr 18, 2023

It's possible for the tests to pass but when the user runs ws install on a harness for the app init step to fail; for example if app init relies on dev dependencies. I had this experience when working on the Spryker harness.

This is due to the fact that when install_environment is run, dev dependencies have previously been installed in the console container and are still present. So an app init that relies on dev dependencies will succeed in the test run but fail when the user actually uses the harness.

Ideally we would have a test_harness_install step that started from a clean environment but this would add a lot of additional time to the test run.

To resolve this issue we need to think of the most efficient way of testing app init as it would run for the user and deployments.

@g-foster2020 g-foster2020 added the bug Something isn't working label Apr 18, 2023
@andytson-inviqa andytson-inviqa changed the title app init can succeed in the test but fail for the user app init can succeed in the test but fail for the user and deployments Apr 18, 2023
@andytson-inviqa
Copy link
Contributor

andytson-inviqa commented Apr 18, 2023

I've updated the title and description to include deployments as affected by the build/test hiding the issue, since they run app init/migrate without dev dependencies (which is correct)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants