Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borrower notification templates are not easily extensible #3842

Open
aw-bib opened this issue Nov 17, 2017 · 0 comments
Open

Borrower notification templates are not easily extensible #3842

aw-bib opened this issue Nov 17, 2017 · 0 comments

Comments

@aw-bib
Copy link
Contributor

aw-bib commented Nov 17, 2017

Basically, due to load_template() implementation in bibcirculationadminlib it is currently not possible to add additional borrower notification forms without changing invenio core code. As the templates available are configured via the CFG_BIBCIRCULATION_TEMPLATES-dictionary, it seems reasonable to allow all keys in this very dict as valid templates.

Thus, the minimal invasive, invisible, change to the code would be to add a further elif statement checking if value passed is a key in the dict and if so just load the template associated. If one wants to restrict templates displayed to the librarian one could then move this kind of config to the bibcirculation_template_<CFG_WEBSTYLE_TEMPLATE_SKIN> for the generation of the associated select-box in html.

isRequiredFor: join2/join2#1066, join2/join2-data#2011

@aw-bib aw-bib added this to the v1.1.8 milestone Nov 17, 2017
@aw-bib aw-bib self-assigned this Nov 17, 2017
aw-bib added a commit to aw-bib/invenio that referenced this issue Nov 20, 2017
* Allow easier extension of borrower notification templates by
resolving all all keys in `CFG_BIBCIRCULATION_TEMPLATES`

Closes inveniosoftware#3842
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant