Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Under-Constrained Problem within PaymentAmountVerifyer #1

Open
Koukyosyumei opened this issue Jan 3, 2025 · 1 comment · May be fixed by #2
Open

Under-Constrained Problem within PaymentAmountVerifyer #1

Koukyosyumei opened this issue Jan 3, 2025 · 1 comment · May be fixed by #2

Comments

@Koukyosyumei
Copy link

Koukyosyumei commented Jan 3, 2025

PaymentAmountVerifyer does not check the output of IsEqual, resulting in the under-constrained problem. Then, this problem propagates to PaymentProcesser and BulkPaymentProcesser.

Specifically, the following malicious assignment satisfies the constraint of PaymentAmountVerifyer:

║    🔍 Assignment Details:
║           ➡️ main.views = 21888242871839275222246405745257275088548364400416034343698204186575808495568
║           ➡️ main.secret = 21888242871839275222246405745257275088548364400416034343698204186575808495606
║           ➡️ main.inv_denominator = 0
║           ➡️ main.secret_mul_denom = 0
║           ➡️ main.out = 0
@Koukyosyumei
Copy link
Author

In addition, it might be better to provide constraints corresponding to the assert statements if it is the expected behavior.

@Koukyosyumei Koukyosyumei linked a pull request Jan 3, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant