Updating old moose simulation #26184
Unanswered
Liserion
asked this question in
Q&A Modules: General
Replies: 5 comments 17 replies
-
|
Hello We have changed vector parameters to no longer have a default recently. So if you had one of these, or a coupledVar parameter, and you were retrieving it without setting it it now errors Guillaume |
Beta Was this translation helpful? Give feedback.
4 replies
-
|
Thank you so much for you answer. I checked my files and concluded that my BC are coupledVar since their calculations involve more than one variable. So the problem is that something in my code is trying to retrieve the value from the BC before it has the value for the calculation? To fix this I have to adjust the execution_on order or do I have to adjust something inside the .C file? Sorry if those are dumb questions, thank you so much for your help tho! |
Beta Was this translation helpful? Give feedback.
-
|
I dont think "involving more than one variable" is the problem Can you share the code? Git repo is best but copy-paste of the object .C file can work too |
Beta Was this translation helpful? Give feedback.
-
|
https://github.com/Liserion/moose_project does this link work? This is the .C of the boudary condition: |
Beta Was this translation helpful? Give feedback.
-
|
For starters, make pps_c2 required as it is retrieved below whether it is passed or not why 'pps' and not 'pp' ? There s only one postprocessor expected right? |
Beta Was this translation helpful? Give feedback.
-
changed it to this and still the same error. I think pps was used just for consistency and it shouldnt effect the code, right? |
Beta Was this translation helpful? Give feedback.
4 replies
-
|
unrelated again but this: can be done at construction instead of during the residual computation. Make sure to store a reference though! Not a number like you do right. Store that reference in the class attributes. For the main problem I am blanking. |
Beta Was this translation helpful? Give feedback.
-
#include "ParticleBVPostBCKernel.h"
registerMooseObject("BabblerApp", ParticleBVPostBCKernel);
template <>
InputParameters validParams<ParticleBVPostBCKernel>()
{
InputParameters params=IntegratedBCBase::validParams();
params.addRequiredParam<PostprocessorName>("pps_c2", "name of pps for c2");
params.addRequiredParam<PostprocessorName>("pps_phi1", "name of pps for phi1");
params.addRequiredParam<PostprocessorName>("pps_phi2", "name of pps for phi2");
params.addRequiredParam<Real>("Cm","The maximum concentration of electrolyte phase");
params.addRequiredParam<Real>("K2","The reaction rate for Bulter-Volmer reaction");
params.addRequiredParam<int>("MateChoice","1->TiS2,"
"2->Mn2O4,"
"3->TiS2 new,"
"4->LiFePO4,"
"5->LiFePO4 from safari,"
"6->V2O5");
params.addParam<Real>("T",298.15,"Temperature(default 298.15)");
return params;
}
ParticleBVPostBCKernel::ParticleBVPostBCKernel(const InputParameters ¶meters)
:IntegratedBC(parameters),
_c2_value(getPostprocessorValue("pps_c2")),
_phi1_value(getPostprocessorValue("pps_phi1")),
_phi2_value(getPostprocessorValue("pps_phi2")),
_Cm(getParam<Real>("Cm")),
_K2(getParam<Real>("K2")),
_MateChoice(getParam<int>("MateChoice")),
_T(getParam<Real>("T")),
_pps_c2(getParam<PostprocessorName>("pps_c2")),
_pps_phi1(getParam<PostprocessorName>("pps_phi1")),
_pps_phi2(getParam<PostprocessorName>("pps_phi2"))
{}
void ParticleBVPostBCKernel::OpenCircuitV(const Real &x, Real &u, Real &dudx)
{
const Real R=8.3144598,F=96485.3329;
if(_MateChoice==1)
{
// For TiS2
// For LiyTiS2 (0.0<x<1.0)
u=2.17+(R*_T/F)*(log(fabs((1-x)/x))-16.2*x+8.1);
dudx=(-16.2*R*_T/F)*(x*x-x-0.0617284)/(x*(x-1));
}
else if(_MateChoice==2)
{
u=4.06279
+0.0677504*tanh(12.8268-21.8502*x)
-0.105734*(pow(1.00167-x,-0.379571)-1.575994)
-0.045*exp(-71.69*pow(x,8))
+0.01*exp(-200.0*(x-0.19));
dudx=-2.0*exp(-200.*(x-0.19))
-0.0401336/pow(1.00167-x,1.37957)
+25.8084*exp(-71.69*pow(x,8))*pow(x,7)
-1.48036*Sech(12.8268-21.8502*x)*Sech(12.8268-21.8502*x);
}
else if(_MateChoice==3)
{
u=2.17+R*_T*(-0.000558*x+8.10)/F;
dudx=R*_T*-0.000558/F;
}
else if(_MateChoice==4)
{
// For LiFePO4
// taken from "Discharge Model for the Lithium Iron-Phosphate Electrode"
// Venkat Srinivasan, DOI: 10.1149/1.1785012
u=3.114559
+4.438792*atan(-71.7352*x+70.85337)
-4.240252*atan(-68.5605*x+67.730082);
dudx=4.438792*(-71.7352)/(1+pow(-71.7352*x+70.85337,2))
+(-4.240252)*(-68.5605)/(1+pow(-68.5605*x+67.730082,2));
}
else if(_MateChoice==5)
{
// For LiFePO4
// taken from Modeling of a Commercial Graphite/LiFePO4 Cell
// Safari doi: 10.1149/1.3567007
u=3.4324
-0.8428*exp(-80.2493*pow(1-x,1.3198))
-(3.2474e-6)*exp(20.2645*pow(1-x,3.8003))
+(3.2482e-6)*exp(20.2646*pow(1-x,3.7995));
dudx=-89.2635*exp(-80.2493*pow(1-x,1.3198))*pow(1-x,0.3198)
+0.000250086*exp(20.2645*pow(1-x,3.8003))*pow(1-x,2.8003)
-0.000250104*exp(20.2646*pow(1-x,3.7995))*pow(1-x,2.7995);
}
else if(_MateChoice==6)
{
// For LiFePO4
// taken from Modeling of a Commercial Graphite/LiFePO4 Cell
// Safari doi: 10.1149/1.3567007
u=3.3059
+0.092769*tanh(-14.362*x+6.6874)
-0.034252*exp(100*(x-0.96))
+0.00724*exp(80.0*(0.01-x));
dudx=1.33235*Sech(6.6874-14.362*x)*Sech(6.6874-14.362*x)
-3.4252*exp(100*(x-0.96))
-0.5792*exp(80*(0.01-x));
}
u=u*F/(R*_T);
dudx=dudx*F/(R*_T);
}
void ParticleBVPostBCKernel::BV(const Real &c, const Real &phi1, const Real &phi2, const Real &cs, Real &J, Real &dJdc)
{
Real U,dUdc;
OpenCircuitV(cs,U,dUdc);
Real eta=phi1-phi2-U;
J=_K2*sqrt((_Cm-c)*c)*(cs*exp(0.5*eta)-(1-cs)*exp(-0.5*eta));
dJdc=_K2*sqrt((_Cm-c)*c)*
(exp(0.5*eta)-0.5*cs*dUdc*exp(0.5*eta)
+exp(-0.5*eta)-0.5*(1-cs)*dUdc*exp(-0.5*eta));
}
//*************************
Real ParticleBVPostBCKernel::computeQpResidual()
{
Real c2 = _c2_value;
Real phi1 = _phi1_value;
Real phi2 = _phi2_value;
BV(c2,phi1,phi2,_u[_qp],J,dJdc);
return J*_test[_i][_qp];
}
Real ParticleBVPostBCKernel::computeQpJacobian()
{
Real c2 = _c2_value;
Real phi1 = _phi1_value;
Real phi2 = _phi2_value;
BV(c2,phi1,phi2,_u[_qp],J,dJdc);
return dJdc*_phi[_j][_qp]*_test[_i][_qp];
}Ill update the files on the rep too. It is still not working but I really appreciate the effort! |
Beta Was this translation helpful? Give feedback.
-
|
Can you run the simulation in devel or debug mode? In your stack frame, I didn't see getParam is called which usually appears when we have "xxx is being retrieved before being set." error. |
Beta Was this translation helpful? Give feedback.
-
|
Sorry that I still haven't responded, I am still in the make process in developer mode. As soon as this is done I will get back to you. Thank you very much for looking over this, too! |
Beta Was this translation helpful? Give feedback.
-
|
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Ok I found the problem First the values are not retrieved with the right name. You need to do this in the initializer list: Then the main problem, validParams has the wrong definition and in the header |
Beta Was this translation helpful? Give feedback.
1 reply
-
|
Sorry I was absent over the weekend Is this because I have just installed the newest Version of moose on my mac? Regardless, I have access to my Linux Computer again and when I did the adjustments I got this error: the Adjustments I have done are the following: .C and .h file: So this means that there are just no values coming from the pps to the micro.i (multiapp), right? Is this then again the fault of the execution order? Again, Thanks a lot for the help |
Beta Was this translation helpful? Give feedback.
-
|
You need to order the intializer list in the constructor the same way that things are declared in the header
|
Beta Was this translation helpful? Give feedback.
8 replies
-
I am still receiving the same error. I have updated the header and C file as you have said. I did get an error when "make" so I changed it to: I still dont quite understand why the parameter is not found now. even tho it is mentioned in the C file.. |
Beta Was this translation helpful? Give feedback.
-
|
You are using PostprocessorName when adding the parameter and std::string when retrieving it You need to be consistent |
Beta Was this translation helpful? Give feedback.
-
|
Thank you! I have updated it and I am left with this error now: can I put a value somewhere for "c2_from_macro" ? The execution_on hasn't quite worked for me... |
Beta Was this translation helpful? Give feedback.
-
|
c2_from_macro? is that a postprocessor in your input? Can you try checking the docstring for getPostprocessorValue ? |
Beta Was this translation helpful? Give feedback.
-
|
I think it is working now, thank you so much! (At least it is running and there havent been any errors, HURRA) |
Beta Was this translation helpful? Give feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hi everybody. I am new to moose and I am currently trying to Update an older simulation (I think it was originally created in 2018, executed again in 2020). Apparently moose has changed quite a lot which is why I had to update some parts. There were some customs kernels which I have been able to update and implement. However, when I now want to run the input file I keep getting the following error:
The parameter is calculated by a postprocessor and should then be sent to a BC. The parameter is not set before the boundary condition is being calculated. I have tried a couple of things including just deleting this part of the input file
which then leads to a functioning simulation.
I have read that when I put 'execute_on='NONE'' that the part wouldn't be executed. When I do that, I still get the same error.
I am also not aware what has changed with moose since the simulation worked in 2020 as far as I know without any errors..
So now I am thinking: does the execute_on not work? I have included my files (Kernels mesh and input files.)
Thank you so much for looking over this!
https://github.com/Liserion/moose_project
Beta Was this translation helpful? Give feedback.
All reactions