-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce number of files in project root #21
Comments
Most of these files belong in the root dir and it is beneficial to keep them there so they are found by CLI commands as well as IDEs (and their plugins), but I'll try to go through them and see how many can be moved or consolidated without breaking that too much. I like to experiment with them anyway. |
One small step towards "Reduce number of files in project root i-am-bee#21" issue. Putting prettier settings in the package.json eliminates one file and works with IDEs, CLI, our yarn format[:fix], etc... Ref: i-am-bee#21 Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
One small step towards "Reduce number of files in project root i-am-bee#21" issue. Putting prettier settings in the package.json eliminates one file and works with IDEs, CLI, our yarn format[:fix], etc... Ref: i-am-bee#21 Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
One small step towards "Reduce number of files in project root i-am-bee#21" issue. Putting prettier settings in the package.json eliminates one file and works with IDEs, CLI, our yarn format[:fix], etc... Ref: i-am-bee#21
@markstur are there pending items or this ready to close? |
There's more. I was tempted to open this up for Hacktoberfest small chores, but need to be more specific about which files can move and where. I'll do that and probably just finish this. |
|
Thanks, I actually have that and some other changes that I just didn't push yet. Will try to get those in on Monday |
To reduce clutter in the root dir, .nvmrc can be removed. Instead of using this file to indicate the version that we prefer, the CONTRIBUTING.md now specifies the version. In the near future, we should bump this version to 22.x, because 20.x recently went into maintenance (22 is active LTS). In addition, with more tests we should go to full support for LTS versions, but for now we are focusing on this one which is the most tested. Part of i-am-bee#21 Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
To reduce clutter in the root dir, .nvmrc can be removed. Instead of using this file to indicate the version that we prefer, the CONTRIBUTING.md now specifies the version. In the near future, we should bump this version to 22.x, because 20.x recently went into maintenance (22 is active LTS). In addition, with more tests we should go to full support for LTS versions, but for now we are focusing on this one which is the most tested. Part of i-am-bee#21 Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Moving .lintstagedrc.json, .release-it.json, and commitlint.config.ts to package.json. Some devs might prefer the separate files, but to support this issue these all can go in package.json. One problem with this is the special function for ignoring dependabot in commit-lint. I haven't found a way to move that ts code into package.json. It does, however, look like dependabot has fixed its problem. So I don't think the ignore is needed. .nvmrc can be moved for devs, but it broke a CI action. So TBD. The .git* files should not move. The *.md files and LICENSE are pretty standard in root. I don't see anything that should move. GitHub recognizes them. docker-compose.yml usually belongs in root (I didn't try moving that one). eslint.config.js could be moved (e.g. to scripts/configs) and then the commands use --config to make this work, but then devs using IDEs would not naturally pick this up so I would not move that one. vitest.config.ts could also move if we use the config option to specify the file with running tests, but vitest then has problems referring back to tsconfig.json and package.json. Probably don't want to move these. |
Some of those are already completed, and this issue is a low priority. |
To reduce clutter in the root dir, .nvmrc can be removed. Instead of using this file to indicate the version that we prefer, the CONTRIBUTING.md now specifies the version. In the near future, we should bump this version to 22.x, because 20.x recently went into maintenance (22 is active LTS). In addition, with more tests we should go to full support for LTS versions, but for now we are focusing on this one which is the most tested. Part of i-am-bee#21 Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
I think we should close this now. We won't be moving .nvmrc (was #117) and we are getting deeper into moving files from their preferred/expected location just to tidy up the github page. Let's not get carried away. If anyone really thinks we should get rid of some others, please open a more specific issue to investigate those. In some cases, the best fix for the clutter is to send people to https://i-am-bee.github.io/bee-agent-framework/#/ and https://github.com/i-am-bee/bee-agent-framework/blob/main/README.md |
I agree with you Mark. Let's close this for now. |
Is your feature request related to a problem? Please describe.
The project root contains a lot of dev/configuration related files that make people need to scroll heavily before getting to the README. Also, these files usually don't convey much useful information about the project.
Describe the solution you'd like
Evaluate each of these files/folder and determine if they could be moved/omitted/replaced/etc.
The text was updated successfully, but these errors were encountered: