Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce number of files in project root #21

Closed
matoushavlena opened this issue Sep 12, 2024 · 12 comments
Closed

Reduce number of files in project root #21

matoushavlena opened this issue Sep 12, 2024 · 12 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest https://hacktoberfest.com

Comments

@matoushavlena
Copy link
Contributor

matoushavlena commented Sep 12, 2024

Is your feature request related to a problem? Please describe.
The project root contains a lot of dev/configuration related files that make people need to scroll heavily before getting to the README. Also, these files usually don't convey much useful information about the project.

Describe the solution you'd like
Evaluate each of these files/folder and determine if they could be moved/omitted/replaced/etc.

@Tomas2D Tomas2D added the good first issue Good for newcomers label Sep 16, 2024
@markstur
Copy link
Contributor

Most of these files belong in the root dir and it is beneficial to keep them there so they are found by CLI commands as well as IDEs (and their plugins), but I'll try to go through them and see how many can be moved or consolidated without breaking that too much. I like to experiment with them anyway.

markstur added a commit to markstur/bee-agent-framework that referenced this issue Sep 19, 2024
One small step towards "Reduce number of files in project root i-am-bee#21" issue.
Putting prettier settings in the package.json eliminates one file and works
with IDEs, CLI, our yarn format[:fix], etc...

Ref: i-am-bee#21

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
markstur added a commit to markstur/bee-agent-framework that referenced this issue Sep 19, 2024
One small step towards "Reduce number of files in project root i-am-bee#21" issue.
Putting prettier settings in the package.json eliminates one file and works
with IDEs, CLI, our yarn format[:fix], etc...

Ref: i-am-bee#21

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
Tomas2D pushed a commit that referenced this issue Sep 19, 2024
One small step towards "Reduce number of files in project root #21" issue.
Putting prettier settings in the package.json eliminates one file and works
with IDEs, CLI, our yarn format[:fix], etc...

Ref: #21
abughali pushed a commit to abughali/bee-agent-framework that referenced this issue Sep 22, 2024
One small step towards "Reduce number of files in project root i-am-bee#21" issue.
Putting prettier settings in the package.json eliminates one file and works
with IDEs, CLI, our yarn format[:fix], etc...

Ref: i-am-bee#21
@mmurad2
Copy link
Member

mmurad2 commented Oct 1, 2024

@markstur are there pending items or this ready to close?

@markstur
Copy link
Contributor

markstur commented Oct 2, 2024

There's more. I was tempted to open this up for Hacktoberfest small chores, but need to be more specific about which files can move and where. I'll do that and probably just finish this.

@Tomas2D
Copy link
Contributor

Tomas2D commented Oct 12, 2024

.lintstagedrc.json can be easily moved to package.json

@Tomas2D Tomas2D added the hacktoberfest https://hacktoberfest.com label Oct 12, 2024
@markstur
Copy link
Contributor

.lintstagedrc.json can be easily moved to package.json

Thanks, I actually have that and some other changes that I just didn't push yet. Will try to get those in on Monday

markstur added a commit to markstur/bee-agent-framework that referenced this issue Oct 14, 2024
To reduce clutter in the root dir, .nvmrc can be removed.  Instead of
using this file to indicate the version that we prefer, the CONTRIBUTING.md
now specifies the version.

In the near future, we should bump this version to 22.x, because 20.x recently
went into maintenance (22 is active LTS).  In addition, with more tests we
should go to full support for LTS versions, but for now we are focusing on
this one which is the most tested.

Part of i-am-bee#21

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur markstur mentioned this issue Oct 14, 2024
8 tasks
markstur added a commit to markstur/bee-agent-framework that referenced this issue Oct 14, 2024
To reduce clutter in the root dir, .nvmrc can be removed.  Instead of
using this file to indicate the version that we prefer, the CONTRIBUTING.md
now specifies the version.

In the near future, we should bump this version to 22.x, because 20.x recently
went into maintenance (22 is active LTS).  In addition, with more tests we
should go to full support for LTS versions, but for now we are focusing on
this one which is the most tested.

Part of i-am-bee#21

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur
Copy link
Contributor

Moving .lintstagedrc.json, .release-it.json, and commitlint.config.ts to package.json. Some devs might prefer the separate files, but to support this issue these all can go in package.json.

One problem with this is the special function for ignoring dependabot in commit-lint. I haven't found a way to move that ts code into package.json. It does, however, look like dependabot has fixed its problem. So I don't think the ignore is needed.

.nvmrc can be moved for devs, but it broke a CI action. So TBD.

The .git* files should not move.
.env.template I do not think should move.
.yarnrc.yml cannot move

The *.md files and LICENSE are pretty standard in root. I don't see anything that should move. GitHub recognizes them.

docker-compose.yml usually belongs in root (I didn't try moving that one).

eslint.config.js could be moved (e.g. to scripts/configs) and then the commands use --config to make this work, but then devs using IDEs would not naturally pick this up so I would not move that one.

vitest.config.ts could also move if we use the config option to specify the file with running tests, but vitest then has problems referring back to tsconfig.json and package.json. Probably don't want to move these.

@timrbula
Copy link

@markstur @Tomas2D Is this issue done given the linked PR is merged or is there a bit more to do?

@Tomas2D
Copy link
Contributor

Tomas2D commented Oct 28, 2024

Some of those are already completed, and this issue is a low priority.

@Tomas2D
Copy link
Contributor

Tomas2D commented Oct 28, 2024

If you would like to contribute, check out #71 and #105.

markstur added a commit to markstur/bee-agent-framework that referenced this issue Oct 28, 2024
To reduce clutter in the root dir, .nvmrc can be removed.  Instead of
using this file to indicate the version that we prefer, the CONTRIBUTING.md
now specifies the version.

In the near future, we should bump this version to 22.x, because 20.x recently
went into maintenance (22 is active LTS).  In addition, with more tests we
should go to full support for LTS versions, but for now we are focusing on
this one which is the most tested.

Part of i-am-bee#21

Signed-off-by: Mark Sturdevant <mark.sturdevant@ibm.com>
@markstur markstur mentioned this issue Oct 28, 2024
8 tasks
@markstur
Copy link
Contributor

I opened #117 to remove .nvmrc with the CI tweak that blocked me earlier.

I could move .husky to scripts(?), but really we use .husky in root pretty consistently. So I think this issue can be closed after 117.
@Tomas2D do you want me to move .husky or dig deeper on any of those remaining dot files?

@markstur
Copy link
Contributor

I think we should close this now. We won't be moving .nvmrc (was #117) and we are getting deeper into moving files from their preferred/expected location just to tidy up the github page. Let's not get carried away. If anyone really thinks we should get rid of some others, please open a more specific issue to investigate those.

In some cases, the best fix for the clutter is to send people to https://i-am-bee.github.io/bee-agent-framework/#/ and https://github.com/i-am-bee/bee-agent-framework/blob/main/README.md

@Tomas2D
Copy link
Contributor

Tomas2D commented Oct 31, 2024

I agree with you Mark. Let's close this for now.

@Tomas2D Tomas2D closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest https://hacktoberfest.com
Projects
None yet
Development

No branches or pull requests

5 participants