Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move embeddings & WikipediaSimilaritySearchTool from API to FW #166

Closed
michael-desmond opened this issue Nov 13, 2024 · 3 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@michael-desmond
Copy link
Contributor

Is your feature request related to a problem? Please describe.
The WikipediaSimilaritySearchTool and the related embedding capabilities are very useful when working with smaller LLMs. For example with granite bee its really the only way to use the Wikipedia tool. Granite will eventually get a larger context window but the ability to chunk/embed/retrieve seems generally useful for tool developers, and provides some core building blocks for optimized tools.

Right now if I want to provide a granite bee + wikipedia example in the FW I cant use the WikipediaSimilaritySearchTool.

Describe the solution you'd like
Move embeddings & WikipediaSimilaritySearchTool from API to FW to make the functionality available at lower level in stack.

Describe alternatives you've considered
Summarization of wikipedia article using an llm post processing step.

Additional context
None.

@Tomas2D Tomas2D added the enhancement New feature or request label Nov 14, 2024
@Tomas2D
Copy link
Contributor

Tomas2D commented Nov 14, 2024

We would need to extend the BaseLLM class to introduce the embeddings by adding a new method (similar to tokenize). This can be done in a separate issue. It would do that instead of bringing new classes in.
Regarding WikipediaSimilaritySearchTool, I would create a general tool instead. That tool would wrap up the provided tool, and that's it.

@Tomas2D Tomas2D self-assigned this Nov 14, 2024
Tomas2D added a commit that referenced this issue Nov 14, 2024
Ref: #166
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Tomas2D added a commit that referenced this issue Nov 14, 2024
Ref: #166
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Tomas2D added a commit that referenced this issue Nov 15, 2024
Ref: #166
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
Tomas2D added a commit that referenced this issue Nov 18, 2024
@Tomas2D
Copy link
Contributor

Tomas2D commented Nov 18, 2024

Such a tool can now be created by using the pipe/extend method available on a tool instance.
Example: https://github.com/i-am-bee/bee-agent-framework/blob/main/examples/tools/custom/piping.ts (v0.0.41)

However the functionality is still blocked by #176

@Tomas2D Tomas2D assigned vabarbosa and unassigned Tomas2D Nov 21, 2024
@Tomas2D
Copy link
Contributor

Tomas2D commented Jan 14, 2025

Embedding has been added and functionality has been refactored in the API.

@Tomas2D Tomas2D closed this as completed Jan 14, 2025
@Tomas2D Tomas2D assigned Tomas2D and unassigned vabarbosa Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants