Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined functions in Lesson 2 #4

Open
VladKha opened this issue Sep 12, 2024 · 2 comments
Open

Undefined functions in Lesson 2 #4

VladKha opened this issue Sep 12, 2024 · 2 comments

Comments

@VladKha
Copy link

VladKha commented Sep 12, 2024

get_url_from_gcs and load_image_from_url used in function print_multimodal_prompt from Lesson 2 are not defined neither in Jupyter notebook, nor in utils.py

Screenshot 2024-09-12 at 02 48 56

Is it expected to be imported from somewhere else?

@Mubsi
Copy link
Collaborator

Mubsi commented Sep 12, 2024

Hi @VladKha,

Good catch!, you are right. But they are not needed in the notebook and can be safely ignored, since you are, in case of:

Running as colab - downloading the images first, and then reading them locally from the colab workspace

Running locally - can read them from your local workspace

@VladKha
Copy link
Author

VladKha commented Sep 12, 2024

@Mubsi, agree, thanks for the prompt reply

IMHO, If this piece of code isn't used anywhere in the course - could make more sense to remove it from the repo to not confuse learners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants