Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider unpacking OTLP arrays #239

Open
cartermp opened this issue Feb 9, 2024 · 1 comment
Open

Consider unpacking OTLP arrays #239

cartermp opened this issue Feb 9, 2024 · 1 comment
Labels
type: enhancement New feature or request

Comments

@cartermp
Copy link
Member

cartermp commented Feb 9, 2024

From a customer request:

[...] ]does Honeycomb accepts array attributes on OpenTelemetry? Their documentation mentions that as a valid attribute type, but when I try to send an array of strings from our testing instrumentation library it seems like what I'm getting is a string representation of the array instead. I'm still investigating if this is happening on the Ruby SDK - the string below suggests this might be the case since the string value in there is exactly what Ruby would output if it generated the string representation of the array in question - but I would appreciate any insights there.

Like in #235, when we see an OTLP array we serialize the whole thing rather than add each element as an attribute.

Now, unlike key:value structures, arrays don't have named keys. So we'd have to consider naming each element based on an index. That might mean:

myArray: ["bananas", "kitty cats", "toilets"]

Would translate into:

{
  ...
  "myArray.0":"bananas",
  "myArray.1":"kitty cats",
  "myArray.2":"toilets",
}
@cartermp cartermp added the type: enhancement New feature or request label Feb 9, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Feb 16, 2024
@MikeGoldsmith MikeGoldsmith removed their assignment Feb 28, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Mar 11, 2024
@MikeGoldsmith MikeGoldsmith removed their assignment Mar 27, 2024
@MikeGoldsmith
Copy link
Contributor

We now track whether a customer is attempting to send array or bytes attributes.

See this shepherd ingest query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants