Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically detected processes with a Procfile #908

Closed
joshwlewis opened this issue Aug 14, 2024 · 1 comment · Fixed by #985
Closed

Automatically detected processes with a Procfile #908

joshwlewis opened this issue Aug 14, 2024 · 1 comment · Fixed by #985

Comments

@joshwlewis
Copy link
Member

Consider an app with an index.js and a Procfile with contents like:

worker: node index.js

When running a build with heroku/builder:24, this results an image with two processes:

web: node index.js
worker: bash -c node index.js

This is probably unexpected for the user. There is an extra process, and the extra web process is unlikely to accept http connections anyway.

My feeling is that we should probably avoid adding processes if we know the the procfile buildpack was detected and is part of the build plan.
@joshwlewis
Copy link
Member Author

Related issue: heroku/buildpacks-go#85

colincasey added a commit that referenced this issue Dec 12, 2024
@colincasey
Skip default process registration when Procfile is present
a78b30f 
This change treats the presence of a `Procfile` as the "source of truth" for how processes should be registered and will skip the default process registration that was previously performed for `npm`, `yarn`, and `pnpm`.

Fixes #908

Related to heroku/buildpacks-go#319
@colincasey colincasey mentioned this issue Dec 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip default process registration when Procfile is present heroku/buildpacks-nodejs
1 participant
@joshwlewis