Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Up/Down direction [Quest export] #13

Closed
Selsynn opened this issue Aug 10, 2018 · 5 comments
Closed

Support for Up/Down direction [Quest export] #13

Selsynn opened this issue Aug 10, 2018 · 5 comments
Labels
enhancement New feature or request

Comments

@Selsynn
Copy link
Contributor

Selsynn commented Aug 10, 2018

Like for the gridborder parameter, I would like the up and down direction to be exported to Quest.
I saw how to specify it in trizbord, but when I exported, the cardinal indication was the thing exported (east / north / west / south)

Like for the other option, I could dig in the code to alter it and push a merge request, if you're interested.

@henck
Copy link
Owner

henck commented Aug 11, 2018

That looks like a bug, because Trizbort.io does support up/down directions. It's exporting them wrong. You're welcome to contribute (see also issue #12).

@henck henck added the enhancement New feature or request label Aug 13, 2019
@henck
Copy link
Owner

henck commented Aug 14, 2019

I can see that Trizbort at this point does not export up/down directions to quest. However, this information is available to export. If I could have a sample Quest XML snippet that shows what the code should look like, I can add the export.

@Happy-Ferret
Copy link
Contributor

I'd be interested in the "secret sauce" to that myself.
I was unable to get "up/down" exports working in general.

Am I right to assume CodeGenerator.dirToStr(dir: Direction) has to be extended to also accept ConnectorType for this to work properly?

@henck
Copy link
Owner

henck commented Aug 14, 2019

@Happy-Ferret Yes. dirToStr should probably be moved out of CodeGenerator, since it might be pretty specific per adventuring system. Indeed, the trick is to find the Direction, and also look at the ConnectorType to see if it's a special case.

Trizbort thinks in terms of 16 directions. The cardinal ones (N,NE,E, ...) and also (NNE, NSE, ...). Any direction may be marked as special. That is, up/down or in/out or even something custom.

For Tads 3 code generation, the Tads generator should have its own dirToStr that performs this check and generate the correct code. For Quest, similar, although I just looked into that and couldn't (quickly) find what Quest expects to find in its XML.

@henck
Copy link
Owner

henck commented Aug 26, 2019

Up/down and in/out support is now available for all generators. dirToStr now takes ConnectorType to make this possible.

@henck henck closed this as completed Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants