-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hemelb::redblood::orientFacets gives inconsistent results when loading deformed mesh #735
Comments
3f7ea8e adds a failing test. @Romain-Enjalbert, if you |
orientFacets method for meshes constructed from a .msh file has been deprecated. A more robust implementation based on VTK provided in a4764ed. We should use VTK input files from now on. |
Hi @mobernabeu - you have added a failing test to the build. Can we remove this test as deprecated? Can we remove some code? |
Yes, we should remove the failing test and the support for .msh files altogether from the code as our implementation of |
As part of #733, @Romain-Enjalbert found that hemelb::redblood::orientFacets will reorder 719 out 720 facets for a mesh that we know has consistent facet orientation throughout.
The text was updated successfully, but these errors were encountered: