New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AffordanceBuilder failing if x-forwarded-port is CSV #3

Open

menelaosbgr opened this issue Mar 5, 2019 · 0 comments

menelaosbgr commented Mar 5, 2019 •

edited

Loading

Hi, we have a problem that when using a zuul proxy behind another proxy, it is possible to have an X-Forwarded-Port value that becomes CSV.

See: spring-cloud/spring-cloud-netflix#1895 (comment)

As a result, hateos fails with a very silly Integer.parseInt error because of the following line:

spring-hateoas-forms/src/main/java/com/github/hateoas/forms/spring/AffordanceBuilder.java

Line 462 in ca30044

builder.port(Integer.parseInt(port));

It would be very simple to detect a CSV list for the port, and simply use the first port.
Would this be an acceptable solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment