Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmarks for operations from containers and hashmap should be disabled by default #333

Closed
sjakobi opened this issue Nov 29, 2021 · 0 comments · Fixed by #341
Closed

Benchmarks for operations from containers and hashmap should be disabled by default #333

sjakobi opened this issue Nov 29, 2021 · 0 comments · Fixed by #341
Labels
benchmarks maintenance

Comments

@sjakobi
Copy link
Member

sjakobi commented Nov 29, 2021

These benchmarks are irrelevant for most performance work, with the possible exception of issues like #319 or #321.

Since runs of the full benchmark suite already take about forever, I suggest that we move these benchmarks behind CPP and/or Cabal flags.
sjakobi added a commit that referenced this issue Dec 19, 2021
@sjakobi
Move comparison benchmarks for containers and hashmap behind CPP
de83942 
Note that configuring cpp-options in the cabal.project is currently
unsupported: haskell/cabal#7872

Closes #333.
@sjakobi sjakobi mentioned this issue Dec 19, 2021
Merged
sjakobi added a commit that referenced this issue Dec 21, 2021
@sjakobi
Move comparison benchmarks for containers and hashmap behind CPP (#341)
b941823 
Note that configuring cpp-options in the cabal.project is currently
unsupported: haskell/cabal#7872

Closes #333.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
benchmarks maintenance
Projects
None yet
Milestone
No milestone
1 participant
@sjakobi