New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify on device: output count starts at 1 not 0 #10

Open

pinheadmz opened this issue Aug 6, 2022 · 0 comments

Member

pinheadmz commented Aug 6, 2022

ledger-app-hns/src/apdu-signature.c

Line 930 in a4ac01e

snprintf(msg, 11, "Output #%d", ++(ui->ctr));

I suppose 1-indexing makes common sense for most users, but it's technically incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment