-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is this repository safty to access our private key #110
Comments
and who knows Handshake how to access our github.com public key? |
I can say that it's safe, but you'll have to ask someone you trust to verify the code :)
GitHub returns the public keys at /.keys. For example, your public key is here: https://github.com/jonwinters.keys |
thanks |
I think the short answer is no, there's no way to provide the password to your SSH private key to a huge pile of javascript in a way that most people would be OK with, and that's sad, because the people who wrote this tool may be trying to do something very nice with nothing dodgy going on. But IMO this tool simply should not have been written this way. Nobody should be giving this thing their password. Sorry. |
Given the lack of progress on #31 it seems it is technically infeasible to claim the airdrop without [potentially] compromising one's private key. The goal of course is to claim the airdrop but not have the airdrop "claiming" you back. AFAICT, the practical options (perhaps in combination) would be to:
|
@natevw thanks for your comment, I agree with everything. Just to answer your question yes the airdrop is based on a snapshot from 2019 and so you are right, the most secure action would be to remove and replace that key from github before using hs-airdrop, and the original key from 2019 is the correct key to sign with. |
In principle, would it be possible to avoid giving the private key to hs-airdrop but instead just sign an hs-airdrop generated message externally, e.g. via gpg? Why is mandatory to give the key? |
Now that I search for it, I do see ways of signing messages with SSH keys using OpenSSL tools that I didn't know about. I think that would have been a better way to do things, but it still seems tolerable to burn the old key and use a new key instead. I needed to move to ed25519 anyway. |
Is this repository safety to access our private key?
I don't know how to code javascript.
The text was updated successfully, but these errors were encountered: