Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sheet elements editable #13

Open
rg-wood opened this issue Feb 17, 2021 · 3 comments
Open

Make sheet elements editable #13

rg-wood opened this issue Feb 17, 2021 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@rg-wood
Copy link
Member

rg-wood commented Feb 17, 2021

Make sheet elements editable so that players can use them online.

This will require some sort of optional persistence, probably in Web Storage, IndexedDB or cookies.

Perhaps support for API storage, maybe in Firebase?
@rg-wood rg-wood added enhancement New feature or request help wanted Extra attention is needed labels Feb 17, 2021
@rg-wood
Copy link
Member Author

rg-wood commented Feb 17, 2021

Bear this in mind:

https://snyk.io/blog/is-localstorage-safe-to-use/

@rg-wood
Copy link
Member Author

rg-wood commented Jul 1, 2022

Completed in eac5a4f.

@rg-wood rg-wood closed this as completed Jul 1, 2022
@rg-wood
Copy link
Member Author

rg-wood commented Jul 1, 2022

Actually, this is only partially completed: the demo character sheet should also demonstrate this feature.

@rg-wood rg-wood reopened this Jul 1, 2022
rg-wood referenced this issue Jul 1, 2022
@rg-wood
Add: save editable sheet values locally
eac5a4f 
As part of this change, the `title` <vellum-sheet-box> attribute had to
be renamed so it is consistent with the <vellum-sheet-field> element.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rg-wood