Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new route appends labels from the previous route until refresh #4720

Closed
teodosii opened this issue Jul 23, 2024 · 0 comments · Fixed by #4721
Closed

Adding new route appends labels from the previous route until refresh #4720

teodosii opened this issue Jul 23, 2024 · 0 comments · Fixed by #4721
Assignees
@teodosii
Labels
bug Something isn't working involved:Frontend more info needed

Comments

@teodosii
Copy link
Member

What went wrong?

What happened:

Adding new route appends labels existing from the previous route until refresh

How do we reproduce it?

Open an integration
Add a route with labels
Add another route

The new route will have labels copied from the previous route, but will persist only until refresh - UI issue

Grafana OnCall Version

latest

Product Area

Other

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response
@teodosii teodosii added the bug Something isn't working label Jul 23, 2024
@teodosii teodosii self-assigned this Jul 23, 2024
@teodosii teodosii changed the title Adding new route appends labels existing from the previous route until refresh Adding new route appends labels from the previous route until refresh Jul 23, 2024
@teodosii teodosii mentioned this issue Jul 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 24, 2024
@teodosii
Set unique key on each rendered route (#4721)
4877b9d 
# What this PR does

- Set the unique key on `Expanded` and `Collapsed` containers, otherwise
React has problems figuring out state for each of them when you append a
new route
- Fixed NPE found by Faro
- Tweaked warnings display of `Routing template not set` and `Routing
labels not set`

## Which issue(s) this PR closes

Closes #4720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodosii teodosii

Labels
bug Something isn't working involved:Frontend more info needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Set unique key on each rendered route grafana/oncall
1 participant
@teodosii