Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slack channel and user group is not populated on first visit of schedule notification settings #4670

Closed
brojd opened this issue Jul 15, 2024 · 0 comments
Closed

Slack channel and user group is not populated on first visit of schedule notification settings #4670

brojd opened this issue Jul 15, 2024 · 0 comments
Assignees
@brojd
Labels
bug Something isn't working part:schedules

Comments

@brojd
Copy link
Contributor

brojd commented Jul 15, 2024 •
edited
Loading

What went wrong?

What happened:

  • I went to existing schedule with already assigned Slack user group and channel
  • I opened notification settings collapsible section
  • Slack channel and user group doesn't have previously saved value
  • Then I collapsed the section and expanded it again - the values get populated

What did you expect to happen:

  • Values populated on first visit
Screen.Recording.2024-07-15.at.07.17.48.mov

How do we reproduce it?

  • Go to existing schedule with already assigned Slack user group and channel
  • Open notification settings collapsible section

Grafana OnCall Version

r383-v1.8.3

Product Area

Schedules

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response
@brojd brojd added the bug Something isn't working label Jul 15, 2024
@brojd brojd self-assigned this Jul 15, 2024
@brojd brojd mentioned this issue Jul 15, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Jul 15, 2024
@brojd
Fix Slack channel and user group values not populating on first visit…
851ca2e 
… of schedule notification settings (#4671)

# What this PR does

Make sure GSelect gets rerendered with updated items., more context
[here](https://raintank-corp.slack.com/archives/C04JCU51NF8/p1720559481963519)

## Which issue(s) this PR closes

#4670

<!--
*Note*: if you have more than one GitHub issue that this PR closes, be
sure to preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
@brojd brojd closed this as completed Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brojd brojd

Labels
bug Something isn't working part:schedules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brojd