Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename user notifications titles inside profile by using more correct wording #3104

Closed
raphael-batte opened this issue Oct 3, 2023 · 2 comments
Closed

Rename user notifications titles inside profile by using more correct wording #3104

raphael-batte opened this issue Oct 3, 2023 · 2 comments
Assignees
@brojd
Labels
bug Something isn't working part:alert flow & configuration

Comments

@raphael-batte
Copy link

What went wrong?

What happened:
At the moment we have Default and Important Notifications as titles inside web UI. Probably, it would be more correct to call these objects a set of personal rules.
image

It
What did you expect to happen:
Suggestions:
1.
Default notification policy
Important notification policy

Default notification rules
Important notification rules

How do we reproduce it?

  1. Open Grafana OnCall and go to user profile section

Grafana OnCall Version

r175-v1.3.1

Product Area

Alert Flow & Configuration

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response
@raphael-batte raphael-batte added the bug Something isn't working label Oct 3, 2023
@raphael-batte raphael-batte changed the title Rename user notifications by using more correct wording Rename user notifications titles inside profile by using more correct wording Oct 3, 2023
@mackgorski
Copy link

mackgorski commented Oct 5, 2023 •
edited
Loading

These ones will be consistent with what we have in our mobile apps.

  • Default notification policy
  • Important notification policy

However in general Rules word is more clear and sounds better, so we could change to this in both places.

@maskin25 maskin25 self-assigned this Jan 18, 2024
@iskhakov
Copy link
Contributor

How high is the priority for that? We will also need to change the documentation

@iskhakov iskhakov mentioned this issue Mar 20, 2024
Closed
@brojd brojd self-assigned this Sep 11, 2024
@brojd brojd mentioned this issue Sep 17, 2024
Merged
3 tasks
@brojd brojd closed this as completed Sep 27, 2024
github-merge-queue bot pushed a commit that referenced this issue Sep 27, 2024
@brojd
docs: update notifications wording (#5030)
2852618 
# What this PR does

update notifications wording

## Which issue(s) this PR closes

Related to #3104 

<!--
*Note*: If you want the issue to be auto-closed once the PR is merged,
change "Related to" to "Closes" in the line above.
If you have more than one GitHub issue that this PR closes, be sure to
preface
each issue link with a [closing
keyword](https://docs.github.com/en/get-started/writing-on-github/working-with-advanced-formatting/using-keywords-in-issues-and-pull-requests#linking-a-pull-request-to-an-issue).
This ensures that the issue(s) are auto-closed once the PR has been
merged.
-->

## Checklist

- [ ] Unit, integration, and e2e (if applicable) tests updated
- [x] Documentation added (or `pr:no public docs` PR label added if not
required)
- [x] Added the relevant release notes label (see labels prefixed w/
`release:`). These labels dictate how your PR will
    show up in the autogenerated release notes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brojd brojd

Labels
bug Something isn't working part:alert flow & configuration
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@iskhakov @maskin25 @joeyorlando @brojd @mackgorski @raphael-batte