Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two thing in src/Model/GameSettings.php #56

Open
lichifeng opened this issue Nov 21, 2017 · 1 comment
Open

Two thing in src/Model/GameSettings.php #56

lichifeng opened this issue Nov 21, 2017 · 1 comment

Comments

@lichifeng
Copy link

In src/Model/GameSettings.php :

1. line 162-170

    /**
     * Returns game speed string.
     *
     * @return string
     */
    public function gameSpeedName()
    {
        return $this->rec->trans('game_speeds', $this->gameSpeed);
    }

$this->gameSpeed could be one of 100, 150, 200, but corresponding array in translation file is:

  'game_speeds' => 
  array (
    0 => 'Slow',
    1 => 'Normal',
    2 => 'Fast',
  ),

I resolved the problem by changing 0, 1, 2 to 100, 150, 200 .

2. line 140-150

/**
     * Returns map style string.
     *
     * @return string
     */
    public function mapStyleName()
    {
        $mapStyle = $this->rec->getResourcePack()
            ->getMapStyle($this->mapId);
        return $this->rec->trans('map_styles', $mapStyle);
    }

Funtion getMapStyle() in this snippet of code seems doesn't exist at all?

Thanks.

@lichifeng
Copy link
Author

0.0 More bugs were found, a lot of them.

I won't issue any more, now learning to use pull request, maybe a better approach to support this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant