Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 [Feature]: Implement Valkey Storage #1361

Open
3 tasks done
H0llyW00dzZ opened this issue May 4, 2024 · 4 comments · May be fixed by #1538
Open
3 tasks done

🚀 [Feature]: Implement Valkey Storage #1361

H0llyW00dzZ opened this issue May 4, 2024 · 4 comments · May be fixed by #1538

Comments

@H0llyW00dzZ
Copy link

Feature Description

This is similar to the Redis link here

Additional Context (optional)

No response

Code Snippet (optional)

No response

Checklist:

  • I agree to follow Fiber's Code of Conduct.
  • I have checked for existing issues that describe my suggestion prior to opening this one.
  • I understand that improperly formatted feature requests may be closed without explanation.
@gaby
Copy link
Member

gaby commented May 4, 2024

@H0llyW00dzZ The Redis and Rueidis clients work with Valkey. Therr's no need for anlther driver.

The valkey-go is a fork of rueidis which we have a storage driver for.

@H0llyW00dzZ
Copy link
Author

@H0llyW00dzZ The Redis and Rueidis clients work with Valkey. Therr's no need for anlther driver.

The valkey-go is a fork of rueidis which we have a storage driver for.

However, that might not work anymore in the future.

@grivera64
Copy link
Member

I think we are at a good point to revisit this issue. According to a December 2024 Redis Blog Post:

And though [Redis and Valkey] were both once based on the same code, they’ve begun to diverge in feature sets,
functionality, capabilities, contributors, and more. Over time, the divergence is only likely to increase.

In this case, it may make sense to officially support Valkey through a separate storage driver. If we do this, we don't need to worry as much about breaking changes between Redis/Rueidis clients and Valkey clients for users that rely on GoFiber's storage module.

Currently, the Valkey client appears to be just enough of the same as Ruedis, so it could be as simple as a copy-and-paste of the existing driver and rename to use Valkey's syntax. This way, once the clients start to vastly diverge, it won't inadvertently break GoFiber applications that upgrade to a future version.

What do you all think of this?

@gaby
Copy link
Member

gaby commented Dec 29, 2024

@grivera64 Agree, the code from the rueidis driver can be copy/pasted, and swap the dependency for https://github.com/valkey-io/valkey-go

@grivera64 grivera64 linked a pull request Jan 4, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants