Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod-rewrite false negative #10

Open
Duke3D opened this issue Apr 20, 2017 · 5 comments
Open

mod-rewrite false negative #10

Duke3D opened this issue Apr 20, 2017 · 5 comments

Comments

@Duke3D
Copy link

Duke3D commented Apr 20, 2017

The method of testing for mod-rewrite creates a false negative due to the testing method being used.
Suggest that either:
a) The testing method be updated to solve the false negative or,
b) Add an ability to ignore the specific error and proceed anyway, which sets a persistent configuration setting that disables the one test
c) Add the ability for the user to select to disable Problems on the Problems page that causes the plugin to be disabled and the Problems page to not render again unless the plugin is re-enabled.
b) Add text to the Problems page explaining how to manually remove the Problems plugin so they can continue on to reaching the Admin User Setup Screen on a properly functioning server,
e) Add instructions for how and when to manually remove the Problems plugin to the Troubleshooting section of the user guide and a link to that Troubleshooting page on the Problems page.

@flaviocopes
Copy link
Contributor

If there is a false positive, we can fix it if you describe your setup. The check is very simple, if using Apache and mod_rewrite is not in the modules list, we raise an issue. Do you have another scenario where mod_rewrite is not detected but you have it installed?

@creopard
Copy link

function apache_get_modules is used to detect mod_rewrite, but this is not reliable way, because this works only when PHP is installed as an Apache module. So it doesn't work with fastCGI, FPM or nginx configurations.

@mahagr
Copy link
Member

mahagr commented Jul 21, 2020

 @creopard Do you have an idea how to make it reliably to work with the other configurations?

@creopard
Copy link

@mahagr I doubt there is a proper way to do it, see for instance: nette/examples#17

@mahagr
Copy link
Member

mahagr commented Jul 24, 2020

CC @rhukster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants