Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queued emails has been empty #143

Open
elceka opened this issue Oct 15, 2020 · 8 comments
Open

Queued emails has been empty #143

elceka opened this issue Oct 15, 2020 · 8 comments

Comments

@elceka
Copy link
Contributor

elceka commented Oct 15, 2020

When i send a test email from news, then received email is with content of news.
But, when i send a newsletter from news for subscribers, then received email is empty.
When i check source code of received email for subscription, then a i see content of news, but only in content-type of text/plain form, not in text/html form.
When i check email sended by testing button from news form, then i see in the source code whole content-type's (text/plain and text/html) of content of email.

@elceka
Copy link
Contributor Author

elceka commented Oct 15, 2020

OK, i get it.
Trouble is when a click tracking or view tracking options are enabled.
Maybe is something wrong in the code in the method addNewsletterLogger() of the class \Indikator\News\Classes\SendNews.

@elceka
Copy link
Contributor Author

elceka commented Oct 15, 2020

I am frustrated...
When i enable back both of tracking options, then queued emails still working...

@TimFoerster
Copy link
Contributor

TimFoerster commented Oct 15, 2020

Which PHP version do you use?

Do you enabled enable_newsletter_content for this post?

@elceka
Copy link
Contributor Author

elceka commented Oct 15, 2020

PHP 7.4, same for web and scheduler.

@TimFoerster
Copy link
Contributor

Looks like we have to rewrite some of that stuff.
I never tested php 7.4.
This might also be a good time to fix #142 by removing the Event listener.
I would also prefer to upgrade everything to Laravel 6 / Ocms v1.1 and use Mailable trait.
@gergo85 What is your opinion about moving to Ocms v1.1?

@elceka
Copy link
Contributor Author

elceka commented Oct 15, 2020

After reenabled tracking options i send newsletter for more then 900 email addresses (because before i tested it many times and it works) and then i see over again empty emails...

@TimFoerster
Copy link
Contributor

Do you use sync driver?

@elceka
Copy link
Contributor Author

elceka commented Oct 15, 2020

No, i use a database driver.
BTW, now, with disabled both tracking options newsletter has been send successfully (i mean with a content 😊 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants