Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive legend for TOC layers [WFS Layer part] #10736

Open
mahmoudadel54 opened this issue Jan 7, 2025 · 0 comments · May be fixed by #10748
Open

Interactive legend for TOC layers [WFS Layer part] #10736

mahmoudadel54 opened this issue Jan 7, 2025 · 0 comments · May be fixed by #10748
Assignees
@mahmoudadel54
Labels
New Feature used for new functionalities
Milestone
2025.01.00

Comments

@mahmoudadel54
Copy link
Contributor

mahmoudadel54 commented Jan 7, 2025 •
edited by tdipisa
Loading

Description

Technically WFS could follow the same workflow of WMS in relation to filtering even if it’s not the optimal solution in terms of performance and request. It would be better to filter directly content already downloaded but this means a review of the current workflow so we could think just these additional tasks:

This is a summary of the expected implementation steps:

1- For the UI part:

  • handle adding checkbox in catalog and layer settings in TOC for enabling/disabling interactive legend [the part in layer settings in TOC --> common with Vector]
  • handle the same behaviour in WMS of hovering effect on the TOC legend items if they present a filter and implement the select effect as well [Add interactivity to the Vector Legend] --> common with Vector

2- For the logic:

  • Now user can create a style includes rules [classification for example] which is on geostyler format
  • in general for WFS filter layer, it is using cql filter expression to filter the layer into the server sending the CQL
  • It will need a converter from geostyler [which comes from classification style for example] to cql that will be needed when user clicks on legend item to implement filter process
  • change in style/disable interactive legend from layer settings will reset the filter like WMS

Other useful information
@mahmoudadel54 mahmoudadel54 added the New Feature used for new functionalities label Jan 7, 2025
@mahmoudadel54 mahmoudadel54 self-assigned this Jan 7, 2025
@tdipisa tdipisa added this to the 2025.01.00 milestone Jan 7, 2025
@mahmoudadel54 mahmoudadel54 mentioned this issue Jan 8, 2025
Closed
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 13, 2025
@mahmoudadel54
geosolutions-it#10736: Interactive legend for TOC layers [WFS Layer p…
d095d2f 
…art]

Description:
- handle the functionality of interactive legend for WFS layers
- create geostyler converter to cql
- handle saving the legend filter of layer into layerFilter object in saving
- handle showing incompatible message in case change into filtered style
- add unit tests
- add translations
@mahmoudadel54 mahmoudadel54 linked a pull request Jan 13, 2025 that will close this issue
Open
12 tasks
@mahmoudadel54 mahmoudadel54 linked a pull request Jan 13, 2025 that will close this issue
#10736: Interactive legend for TOC layers [WFS Layer part] #10748
Open
12 tasks
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 13, 2025
@mahmoudadel54
geosolutions-it#10736: fix FE unit tests for CommonAdvancedSettings
ccce090
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 17, 2025
@mahmoudadel54
geosolutions-it#10736: Interactive legend for TOC layers [WFS Layer p…
9101a94 
…art] (resolve reviews)

- fix issue of activating interactive legend even if experimentalInteractiveLegend = false in localConfig
- remove serverType check for wfs  interactivity legend display
- replace owner prop with interactive prop for wms and wfs
- handle not calling legend filter handler in case not activate the interactivity or no rule to apply
- add double check for geostyler if it is a direct array or has body in converter file
- reset miscSettings in CommonAdvancedSettings test file in afterEach
- add tranlations
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 17, 2025
@mahmoudadel54
geosolutions-it#10736: fix issue due to merge master
edecb3a
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Jan 17, 2025
@mahmoudadel54
geosolutions-it#10736: fix FE unit test failure
fbdba19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mahmoudadel54 mahmoudadel54

Labels
New Feature used for new functionalities
Projects
None yet
Milestone
2025.01.00
Development

Successfully merging a pull request may close this issue.

#10736: Interactive legend for TOC layers [WFS Layer part] mahmoudadel54/MapStore2
2 participants
@tdipisa @mahmoudadel54