Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show list of supported client applications #72

Closed
nichtich opened this issue Jan 13, 2021 · 3 comments
Closed

Show list of supported client applications #72

nichtich opened this issue Jan 13, 2021 · 3 comments
Labels
feature undefined
Milestone

Comments

@nichtich
Copy link
Member

nichtich commented Jan 13, 2021

In addition to #70 show supported client applications without active session and assign names to active sessions. This requires an additional config file applications.json:

[
  { "url": "//bartoc.org/", "name": "BARTOC" },
  { "url": "//coli-conc.gbv.de/cocoda/", "name": "Cocoda" },
  { "url": "//coli-conc.gbv.de/coli-rich/", "name": "coli-rich" }
]

Some sessions can be mapped to applications to show their name instead of the URL.

@nichtich nichtich added the feature undefined label Jan 13, 2021
nichtich added a commit that referenced this issue Jan 13, 2021
Make clear the data is shared with selected applications and link to
/sessions for more information (should be done with #72).
@stefandesu stefandesu added this to the 0.4.0 milestone Jan 14, 2021
stefandesu added a commit that referenced this issue Jan 14, 2021
Will show the application name after implemented in #72.
@stefandesu
Copy link
Member

If we add an applications.json file, we have two options:

  1. Either we don't commit it into the repo, thus every instance needs to provide its own file,
  2. or we do commit it, but there's no easy way of adding additional applications.

I tend towards 1. In theory, we could have a default set of applications (either hardcoded or in a applications.default.json). What do you think?

@nichtich
Copy link
Member Author

ALLOWED_ORIGINS has no default value neither, so

  1. The list of applications is empty if no applications.json exists.

@stefandesu
Copy link
Member

The list of applications is empty if no applications.json exists.

So 1. 😉 The default set was just a thought and basically my number 3.

stefandesu added a commit that referenced this issue Jan 18, 2021
Reword help about data sharing
#27, #66, #70, #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature undefined
Projects
None yet
Development

No branches or pull requests

2 participants