Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup user interface #66

Closed
5 tasks done
nichtich opened this issue Jan 6, 2021 · 5 comments
Closed
5 tasks done

Cleanup user interface #66

nichtich opened this issue Jan 6, 2021 · 5 comments
Labels
cleanup undefined
Milestone

Comments

@nichtich
Copy link
Member

nichtich commented Jan 6, 2021

@nichtich nichtich added the cleanup undefined label Jan 6, 2021
@nichtich nichtich added this to the 0.4.0 milestone Jan 6, 2021
@stefandesu
Copy link
Member

To be honest, I sometimes get confused myself with the different subpages of login-server. These are my thoughts at the moment:

  • When accessing / and the user is not logged in, it should redirect to /login.
  • What's now under /account should actually be under / (or / redirects to /account if the user is logged in).
  • But the information (maybe in a more concise form) from / should be somewhere, maybe shown on /login?

@nichtich
Copy link
Member Author

nichtich commented Jan 7, 2021

When accessing / and the user is not logged in, it should redirect to /login
What's now under /account should actually be under / (or / redirects to /account if the user is logged in).

The text shown at / could be put under "/about" or "/help" (see #27) and / perform a redirect to /login or account. To better organize the subpages I recommend a header navigation with three pages:

  • about (the current /): general information about the service
  • account: name and connected identities or login. "logout" and "delete user account" can also be moved this page
  • sessions or "clients": active sessions. This would be more informative if we had information about the client a session originated in. We could add a static list of known client applications (BARTOC, coli-conc, coli-rich), at least.

@stefandesu
Copy link
Member

  • /about is already an API endpoint for information about the server, so we should use /help instead. But in the navigation it can still be called "About", that definitely works better.
  • I would still show "Logout" in the top right of the page, but I'd be fine with removing the "Logged in as" text.
  • I'll take a look at the sessions page and try to improve it.

stefandesu added a commit that referenced this issue Jan 12, 2021
@stefandesu
Copy link
Member

I added the header and restructured everything a bit (haven't looked at sessions yet though). Please take a look, @nichtich:

Screen.Recording.2021-01-12.at.11.22.32.mov

stefandesu added a commit that referenced this issue Jan 12, 2021
@stefandesu
Copy link
Member

  • sessions or "clients": active sessions. This would be more informative if we had information about the client a session originated in. We could add a static list of known client applications (BARTOC, coli-conc, coli-rich), at least.

I'm not sure how to determine where a session originated. I guess we could save the referrer (i.e. when the user logs in from Cocoda). My suggestion: On the server, when either /login or /login/:provider are requested and a referrer other than the login server URL is given, and if the user is not currently logged in, save that referrer inside a field in the session.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup undefined
Projects
None yet
Development

No branches or pull requests

2 participants