Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation broken on master #53

Open
graftholders-dev opened this issue Nov 15, 2024 · 2 comments
Open

Compilation broken on master #53

graftholders-dev opened this issue Nov 15, 2024 · 2 comments

Comments

@graftholders-dev
Copy link

In my cmake:

FetchContent_Declare(CppLinuxSerial # name of the content
  GIT_REPOSITORY https://github.com/gbmhunter/CppLinuxSerial.git # the repository
  GIT_TAG master # the tag
)

if(NOT CppLinuxSerial_POPULATED)
  FetchContent_Populate(CppLinuxSerial)
  add_subdirectory(${cpplinuxserial_SOURCE_DIR} ${cpplinuxserial_BINARY_DIR} EXCLUDE_FROM_ALL)
endif()

FetchContent_MakeAvailable(CppLinuxSerial)
message("CppLinuxSerial fetched")

With master, now I have

/home/triccyx/Documents/mini/ENRG_GR02905_BITRON_OCPP_LIBRARY/build/_deps/cpplinuxserial-src/include/CppLinuxSerial/SerialPort.hpp:123:51: error: ‘speed_t’ has not been declared
  123 |             SerialPort(const std::string &device, speed_t baudRate);

If I switch to tag=v2.8.2 all is ok.

@gbmhunter
Copy link
Owner

Ahh woops I think this is the result of this MR I merged in yesterday: 5db4fa6

Specifically, it's probably the removal of #include <asm/termbits.h> from the serial port header file which has done it. I'll re-add it back in.

@gbmhunter gbmhunter mentioned this issue Nov 15, 2024
@gbmhunter
Copy link
Owner

@graftholders-dev I've pushed a potential fix, could you try the latest master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants