Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insert button changes changes shape on click #19361

Open
mvdbeek opened this issue Dec 20, 2024 · 4 comments
Open

Insert button changes changes shape on click #19361

mvdbeek opened this issue Dec 20, 2024 · 4 comments

Comments

@mvdbeek
Copy link
Member

mvdbeek commented Dec 20, 2024

Release Notes
This Galaxy server version is 25.0.dev0, and the web client was built on Wednesday Dec 4th 10:32:30 2024 GMT-8 .

Only in MAC/Safari , Chrome and Firefox are Ok.

  1. Clicking on "insert" make the button scrunch up. This is true even if the window is expanded to be "wide" when I click.
  2. Opening that panel really wide then going narrow again resize correctly.
  3. Clicking on "copy" also resets to the right size.
  4. I see that removing these excess published workflow is planned for 24.2. Maybe this is minor since these won't be listed at all soon.

Screen Shot 2024-12-19 at 1 26 47 PM

Originally posted by @jennaj in #19265 (comment)

@itisAliRH
Copy link
Member

@mvdbeek I couldn't reproduce this issue on Safari 18.2. The insert button for shared workflows is not working now and the import button should not be there either (no need for that). But the shared workflows are dropped from this activity in #19312

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 9, 2025

Ah, right, that button can definitely not appear in that context. For completeness, can you check if the import button needs any tweaks ? I think it's defined here: https://github.com/galaxyproject/galaxy/blob/release_24.2/client/src/components/Workflow/List/WorkflowActionsExtend.vue#L182-L192

@itisAliRH
Copy link
Member

@mvdbeek Yes. The import button should not be there too as it is not relevant to the editor functionality. Only the copy is working for not-owned public workflows and can be there. Should I push a temporary fix in 24.2?

@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 9, 2025

Sorry, what I meant is that there is no import button in the editor, but can you check that where the button is actually visible it behaves correctly ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants