From da6eede8d89025c3e80982c3063f8fea023deece Mon Sep 17 00:00:00 2001
From: Alireza Heidari <itisalirh@gmail.com>
Date: Thu, 13 Jun 2024 12:29:19 +0200
Subject: [PATCH 1/3] =?UTF-8?q?=F0=9F=90=9B:=20fix=20`DatasetDetails`=20re?=
 =?UTF-8?q?render=20issue=20on=20job=20loading?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 client/src/components/DatasetInformation/DatasetDetails.vue | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/client/src/components/DatasetInformation/DatasetDetails.vue b/client/src/components/DatasetInformation/DatasetDetails.vue
index 667e33d2c802..4481ad774676 100644
--- a/client/src/components/DatasetInformation/DatasetDetails.vue
+++ b/client/src/components/DatasetInformation/DatasetDetails.vue
@@ -102,7 +102,7 @@ onUnmounted(() => {
             {{ datasetLoadingError }}
         </BAlert>
         <div v-else-if="dataset">
-            <div v-if="dataset.creating_job && !jobLoading" class="details">
+            <div v-if="dataset.creating_job" class="details">
                 <DatasetInformation :dataset="dataset" />
 
                 <JobParameters dataset_type="hda" :dataset-id="datasetId" />
@@ -124,7 +124,9 @@ onUnmounted(() => {
 
                 <JobDestinationParams v-if="currentUser?.is_admin" :job-id="dataset.creating_job" />
 
-                <JobDependencies v-if="jobDetails.dependencies" :dependencies="jobDetails.dependencies" />
+                <JobDependencies
+                    v-if="!jobLoading && jobDetails.dependencies"
+                    :dependencies="jobDetails.dependencies" />
 
                 <div v-if="dataset.peek">
                     <h2 class="h-md">Dataset Peek</h2>

From 57191edfbfa72bef1db289bac46874298b24e81f Mon Sep 17 00:00:00 2001
From: Alireza Heidari <itisalirh@gmail.com>
Date: Thu, 13 Jun 2024 13:35:14 +0200
Subject: [PATCH 2/3] =?UTF-8?q?=F0=9F=94=A8:=20update=20job=20dependencies?=
 =?UTF-8?q?=20rendering=20in=20`DatasetDetails`?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 client/src/components/DatasetInformation/DatasetDetails.vue | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/client/src/components/DatasetInformation/DatasetDetails.vue b/client/src/components/DatasetInformation/DatasetDetails.vue
index 4481ad774676..8fc632bd8bf8 100644
--- a/client/src/components/DatasetInformation/DatasetDetails.vue
+++ b/client/src/components/DatasetInformation/DatasetDetails.vue
@@ -124,9 +124,7 @@ onUnmounted(() => {
 
                 <JobDestinationParams v-if="currentUser?.is_admin" :job-id="dataset.creating_job" />
 
-                <JobDependencies
-                    v-if="!jobLoading && jobDetails.dependencies"
-                    :dependencies="jobDetails.dependencies" />
+                <JobDependencies v-if="jobDetails?.dependencies" :dependencies="jobDetails.dependencies" />
 
                 <div v-if="dataset.peek">
                     <h2 class="h-md">Dataset Peek</h2>

From 092b77f06fdcf60b24cea64610621fa26df0a335 Mon Sep 17 00:00:00 2001
From: Alireza Heidari <itisalirh@gmail.com>
Date: Thu, 13 Jun 2024 14:56:56 +0200
Subject: [PATCH 3/3] =?UTF-8?q?=F0=9F=94=A8:=20remove=20unused=20`jobLoadi?=
 =?UTF-8?q?ng`=20ref=20in=20`DatasetDetails`?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 client/src/components/DatasetInformation/DatasetDetails.vue | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/client/src/components/DatasetInformation/DatasetDetails.vue b/client/src/components/DatasetInformation/DatasetDetails.vue
index 8fc632bd8bf8..7680606b3106 100644
--- a/client/src/components/DatasetInformation/DatasetDetails.vue
+++ b/client/src/components/DatasetInformation/DatasetDetails.vue
@@ -33,7 +33,6 @@ const userStore = useUserStore();
 const { currentUser } = storeToRefs(userStore);
 
 const loading = ref(false);
-const jobLoading = ref(true);
 const jobTimeOut = ref<any>(null);
 const jobDetails = ref<JobDetails>();
 const dataset = ref<HDADetailed | null>(null);
@@ -57,8 +56,6 @@ async function getDatasetDetails() {
 }
 
 async function loadJobDetails() {
-    jobLoading.value = true;
-
     try {
         const { data } = await fetchJobDetails({ job_id: dataset.value?.creating_job as string, full: true });
 
@@ -73,8 +70,6 @@ async function loadJobDetails() {
         const error = e as AxiosError<{ err_msg?: string }>;
 
         jobLoadingError.value = error.response?.data?.err_msg || "Unable to fetch available dataset details.";
-    } finally {
-        jobLoading.value = false;
     }
 }