Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASE vs MDTraj vs nothing #8

Open
OndrejMarsalek opened this issue Apr 4, 2018 · 3 comments
Open

ASE vs MDTraj vs nothing #8

OndrejMarsalek opened this issue Apr 4, 2018 · 3 comments

Comments

@OndrejMarsalek
Copy link
Collaborator

It would be nice if ILI could work with an MDTraj trajectory, rather than ASE atoms. For processing trajectories, constructing ASE atoms for each frame seems wasteful. I don't mind atoms as an alternative if you think it's useful. Possibly even better - we could again separate specific "formats" of input from just feeding individual arguments to the constructor.

@OndrejMarsalek
Copy link
Collaborator Author

In any case, not really a priority, but I'd like to come back to it at some point.

@fuulish
Copy link
Owner

fuulish commented Apr 6, 2018

AFAICT, you need not construct individual atoms objects for each snapshot in a trajectory. It should work by just updating the positions. However, I agree that working on and MDTraj object would have some advantages.
Let's keep the issue open, so that we don't forget and can come back to it, later

@OndrejMarsalek
Copy link
Collaborator Author

Fair, that should work, though ASE atoms are still relatively heavyweight. It would be best if both are supported, eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants