Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Ability to have multi layer first walls #302

Open
Allentro opened this issue Jan 28, 2023 · 1 comment
Open

[Feature Request] Ability to have multi layer first walls #302

Allentro opened this issue Jan 28, 2023 · 1 comment

Comments

@Allentro
Copy link

I think it would be a useful addition to have multi layer firstwalls. This would enable more realistic constructions which often include plasma facing material, thermal conducting interlayer and a structural layer.

@Allentro Allentro changed the title Ability to have multi layer first walls [Feature Request] Ability to have multi layer first walls Jan 28, 2023
@shimwell
Copy link
Member

This sounds like a great idea to me. I'm thinking it is such a nice addition that it could be expanded to apply to all layers.

Currently the reactors tend to have 3 layers but if the could have n layers that would be great.

It will certainly allow a larger variety of reactors to be made but it might also shorten the amount of code.

It would effectively turn all the reactors into onion reactors.

I say we merge in the PR you have kindly opened but perhaps consider refactoring the reactor layer creation more radically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants